Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted empty App.css #14149

Merged
merged 1 commit into from Feb 19, 2019
Merged

Deleted empty App.css #14149

merged 1 commit into from Feb 19, 2019

Conversation

JoshuaRabiu
Copy link
Contributor

Came across this empty App.css file & deleted it. Looks like the last commit in that folder was deleting vestigial CRA files, so I'm thinking this was a missed file.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@sizebot
Copy link

sizebot commented Nov 8, 2018

Details of bundled changes.

Comparing: 051272f...8423b99

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler.development.js n/a n/a 0 B 19.17 KB 0 B 5.74 KB UMD_DEV
scheduler.production.min.js n/a n/a 0 B 3.16 KB 0 B 1.53 KB UMD_PROD

Generated by 🚫 dangerJS

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link

@vikaskyadav vikaskyadav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we are not using this anywhere?

@JoshuaRabiu
Copy link
Contributor Author

@vikaskyadav Yes, a search reveals that it isn't being used anywhere: https://github.com/facebook/react/search?q=app.css&unscoped_q=app.css

@nhunzaker
Copy link
Contributor

Ya. That's definitely the case. Thanks!

@nhunzaker nhunzaker merged commit 1493abd into facebook:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants