Improved suspense support in ReactDOMServer #14161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: f9e9913...7483480 react-dom
scheduler
Generated by 🚫 dangerJS |
alexmckenley
force-pushed
the
ReactDOMServerSuspense
branch
4 times, most recently
from
993d094
to
e7ec765
Compare
|
Updated based on recommendations from @sophiebits. 💯 |
sophiebits
approved these changes
Nov 9, 2018
alexmckenley
force-pushed
the
ReactDOMServerSuspense
branch
from
e7ec765
to
7483480
Compare
|
@sophiebits Thanks for the review! I pushed up the changes, but I dont see a merge button, seems like I may not have permission. |
|
dom/src/server/ReactPartialRenderer.js
index 643d53cf0c3..c5f124e7c4a 100644
Can't be running in js try using HTML script for the patch for #6846
…On Thu, Nov 8, 2018, 6:54 PM Alex Taylor ***@***.*** wrote:
Updated based on recommendations from @sophiebits
<https://github.com/sophiebits>. 💯
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#14161 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AYjb0Li0DKHPcI-IuFII33pQnteWecrdks5utNI5gaJpZM4YVuTD>
.
|
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the support for suspense in the ReactPartialRenderer. Instead of always rendering the fallback, the server renderer will attempt to render the children, and only revert to the fallback if rendering is suspended with a thrown promise.
Let me know what you think.