--save is no longer needed #14302
--save is no longer needed #14302
Conversation
`--save` is on by default as of npm 5. `npm install create-subscription` is equivalent to `npm install --save create-subscription` now
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Not everyone has/or is using NPM v5. Might be safer to keep it around? |
|
npm 5 came out a year and a half ago, so it would only effect npm <=4. How far back does React support npm versions? |
|
I think it's good to note explicitly because there may still be users using previous versions of NPM. |
|
And what do you think about leaving it like that? npm install create-subscription --save
|
|
This pr just maintains consistency in this project, and most other major projects using npm. A year and a half is an eternity in js frameworks, especially something that only lives client-side |
|
That said, I think you should close this PR @SamCortopassi |
|
@devrchancay why? It's a good pr, it updates the docs |
|
@gaearon good to merge for consistency? |
|
??? |
|
Looks good to me, merging. Thanks @JoeCortopassi! |
`--save` is on by default as of npm 5. `npm install create-subscription` is equivalent to `npm install --save create-subscription` now
--saveis on by default as of npm 5.npm install create-subscriptionis equivalent tonpm install --save create-subscriptionnow