Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up NPM checkout process #14631

Merged

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jan 18, 2019

Just a tiny follow up to clean up the process of promoting a canary to a stable release.

Downloading the tar from NPM prevents the client from adding all of the registry metadata, changing the order of package JSON keys, etc. – so the delta between the canary and the resulting master is smaller.

It also avoids checking out all of the NPM dependencies, so it's potentially slightly faster.

@bvaughn bvaughn force-pushed the release-script-prepare-stable-refactor branch from 7163992 to be12a61 Compare January 18, 2019 19:30
Copy link
Collaborator

@acdlite acdlite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank youuu

@bvaughn bvaughn merged commit 8c1614a into facebook:master Jan 18, 2019
@bvaughn bvaughn deleted the release-script-prepare-stable-refactor branch January 18, 2019 19:40
jetoneza pushed a commit to jetoneza/react that referenced this pull request Jan 23, 2019
n8schloss pushed a commit to n8schloss/react that referenced this pull request Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants