Revert "Disallow reading context during useMemo etc" #14651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
added a commit
that referenced
this pull request
Jan 21, 2019
…Mode" (#14652) * Revert "Revert "Disallow reading context during useMemo etc" (#14651)" This reverts commit 5fce648. * Revert "Add test coverage for readContext() on the server (#14649)" This reverts commit fe2ecd2. * Revert "Warn about incorrect use of useImperativeHandle() (#14647)" This reverts commit 8f45a7f. * Revert "Disallow reading context during useMemo etc (#14648)" This reverts commit 1fcbd22. * Revert "Warn about refs on lazy function components (#14645)" This reverts commit 2a084f5. * Revert "Fix typo (#14560)" This reverts commit b5a3df6. * Revert "fix typo (#14316)" This reverts commit 9c146e6. * Revert "Mention forwardRef() in <Fn ref={...} /> errors and warnings (#14644)" This reverts commit baa6d40. * Revert "Double-render function components with Hooks in DEV in StrictMode (#14643)" This reverts commit a1414e8.
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
* Revert "Add test coverage for readContext() on the server (facebook#14649)" This reverts commit fe2ecd2. * Revert "Warn about incorrect use of useImperativeHandle() (facebook#14647)" This reverts commit 8f45a7f. * Revert "Disallow reading context during useMemo etc (facebook#14648)" This reverts commit 1fcbd22.
jetoneza
pushed a commit
to jetoneza/react
that referenced
this pull request
Jan 23, 2019
…Mode" (facebook#14652) * Revert "Revert "Disallow reading context during useMemo etc" (facebook#14651)" This reverts commit 5fce648. * Revert "Add test coverage for readContext() on the server (facebook#14649)" This reverts commit fe2ecd2. * Revert "Warn about incorrect use of useImperativeHandle() (facebook#14647)" This reverts commit 8f45a7f. * Revert "Disallow reading context during useMemo etc (facebook#14648)" This reverts commit 1fcbd22. * Revert "Warn about refs on lazy function components (facebook#14645)" This reverts commit 2a084f5. * Revert "Fix typo (facebook#14560)" This reverts commit b5a3df6. * Revert "fix typo (facebook#14316)" This reverts commit 9c146e6. * Revert "Mention forwardRef() in <Fn ref={...} /> errors and warnings (facebook#14644)" This reverts commit baa6d40. * Revert "Double-render function components with Hooks in DEV in StrictMode (facebook#14643)" This reverts commit a1414e8.
gaearon
added a commit
that referenced
this pull request
Jan 23, 2019
* Revert "Revert "Double-render function components with Hooks in DEV in StrictMode" (#14652)" This reverts commit 3fbebb2. * Revert "Revert "Disallow reading context during useMemo etc" (#14651)" This reverts commit 5fce648. * Add extra passing test for an edge case Mentioned by @acdlite to watch out for * More convoluted test * Don't rely on expirationTime Addresses @acdlite's concerns * Edge case: forbid readContext() during eager reducer
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
* Revert "Add test coverage for readContext() on the server (facebook#14649)" This reverts commit fe2ecd2. * Revert "Warn about incorrect use of useImperativeHandle() (facebook#14647)" This reverts commit 8f45a7f. * Revert "Disallow reading context during useMemo etc (facebook#14648)" This reverts commit 1fcbd22.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
…Mode" (facebook#14652) * Revert "Revert "Disallow reading context during useMemo etc" (facebook#14651)" This reverts commit 5fce648. * Revert "Add test coverage for readContext() on the server (facebook#14649)" This reverts commit fe2ecd2. * Revert "Warn about incorrect use of useImperativeHandle() (facebook#14647)" This reverts commit 8f45a7f. * Revert "Disallow reading context during useMemo etc (facebook#14648)" This reverts commit 1fcbd22. * Revert "Warn about refs on lazy function components (facebook#14645)" This reverts commit 2a084f5. * Revert "Fix typo (facebook#14560)" This reverts commit b5a3df6. * Revert "fix typo (facebook#14316)" This reverts commit 9c146e6. * Revert "Mention forwardRef() in <Fn ref={...} /> errors and warnings (facebook#14644)" This reverts commit baa6d40. * Revert "Double-render function components with Hooks in DEV in StrictMode (facebook#14643)" This reverts commit a1414e8.
n8schloss
pushed a commit
to n8schloss/react
that referenced
this pull request
Jan 31, 2019
* Revert "Revert "Double-render function components with Hooks in DEV in StrictMode" (facebook#14652)" This reverts commit 3fbebb2. * Revert "Revert "Disallow reading context during useMemo etc" (facebook#14651)" This reverts commit 5fce648. * Add extra passing test for an edge case Mentioned by @acdlite to watch out for * More convoluted test * Don't rely on expirationTime Addresses @acdlite's concerns * Edge case: forbid readContext() during eager reducer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #14648
Let's first reach agreement on the approach.