Tweak invalid Hook warning and error #14747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threepointone
approved these changes
Feb 1, 2019
| ); | ||
| if (__DEV__) { | ||
| warning( | ||
| !isInHookUserCodeInDev, | ||
| 'Hooks can only be called inside the body of a function component. ' + | ||
| 'Do not call Hooks inside other Hooks. For more information, see ' + | ||
| 'Do not call Hooks inside useEffect(...), useMemo(...), or other built-in Hooks. ' + |
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a link to https://reactjs.org/warnings/invalid-hook-call-warning.html for the invariant. (I guess it's not a warning.. but I also don't want to introduce a new URL naming scheme. We don't have separate pages for errors right now. We can move it later if it causes confusion but I'm not sure it would.)
Rewords the warning when we know more exactly what happened.