Unify noop and test renderer assertion APIs #14952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: 3989c09...ce0d4bb react-noop-renderer
Generated by 🚫 dangerJS |
Test renderer already does this. Makes it harder to miss unexpected behavior by forcing you to assert on every logged value.
The matchers warn if work is flushed while the log is empty. This is the pattern we already follow for test renderer. I've used the same APIs as test renderer, so it should be easy to switch between the two.
acdlite
force-pushed
the
unifynoopandtestapis
branch
from
d3fe0bc
to
ce0d4bb
Compare
sebmarkbage
approved these changes
Feb 26, 2019
NMinhNguyen
referenced
this pull request
in enzymejs/react-shallow-renderer
Jan 29, 2020
* Throw in tests if work is done before emptying log Test renderer already does this. Makes it harder to miss unexpected behavior by forcing you to assert on every logged value. * Convert ReactNoop tests to use jest matchers The matchers warn if work is flushed while the log is empty. This is the pattern we already follow for test renderer. I've used the same APIs as test renderer, so it should be easy to switch between the two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The matchers will fail if you flush work while the log is empty. Makes it harder to miss unexpected
behavior by forcing you to assert on every logged value. This is the pattern we already follow for test renderer. I've used the same APIs as test renderer, so it should be easy to switch between the two.
This is a large diff but it's mostly a big find-and-replace. The most important changes are in createReactNoop and reactTestMatchers.