Fix act() tests by properly unmounting the container #14974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -678,6 +665,39 @@ describe('ReactTestUtils', () => { | |||
| ); | |||
| }); | |||
|
|
|||
| it('flushes immediate re-renders with act but advances timers later', () => { | |||
There was a problem hiding this comment.
act doesn't advance timers at all, so this title is a bit wrong.
There was a problem hiding this comment.
Right, removed that part.
threepointone
approved these changes
Feb 28, 2019
philipp-spiess
force-pushed
the
act-test-fixes
branch
from
1171f94
to
b5e91d5
Compare
philipp-spiess
force-pushed
the
act-test-fixes
branch
from
b5e91d5
to
d16f798
Compare
|
@threepointone Rebased my PR but the issue I noticed earlier is no longer happening (the missing |
|
Thank you, it just slipped my mind! I do think your structure is better, I'll merge it in today. |
|
React: size: -0.4%, gzip: 🔺+0.4% ReactDOM: size: -1.4%, gzip: -0.8% Details of bundled changes.Comparing: 543353a...d16f798 react
react-dom
react-art
react-test-renderer
react-noop-renderer
react-reconciler
react-native-renderer
scheduler
react-events
Generated by 🚫 dangerJS |
|
lol @sizebot go home, you're drunk |
|
@threepointone For the future — it's a good idea to always do cleanup in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing around with the new
act()API I discovered a test thatwas unexpectedly failing. After some digging I noticed that the test is
passing when run in isolation and that the test suite can be fixe by
properly calling
ReactDOM.unmountComponentAtNode()to clean up afterevery test run.
You can reproduce the issue by simply commenting out the call to
unmountComponentAtNodein theafterEachcallback. The newly addedtest will fail but pass in isolation.
I thought it would be a good idea to fix this upstream so nobody runs
into this issue again.