[ESLint] Tweak setState updater message and add useEffect(async) warning #15055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In-person testing showed using original variable name confuses people.
threepointone
approved these changes
Mar 7, 2019
| @@ -2304,7 +2327,7 @@ const tests = { | |||
| errors: [ | |||
| "React Hook useEffect has a missing dependency: 'state'. " + | |||
| 'Either include it or remove the dependency array. ' + | |||
| `You can also write 'setState(state => ...)' ` + | |||
| `You can also write 'setState(s => ...)' ` + | |||
There was a problem hiding this comment.
why did you decide to do a single character here?
There was a problem hiding this comment.
Showed it to people and they were confused seeing the same variable name because it wasn't obvious it's being shadowed. This explanation clicked tho.
There was a problem hiding this comment.
I guess I'm open to other changes, just want to avoid the shadowing. If people think this is confusing we can brainstorm more options.
There was a problem hiding this comment.
No I trust your judgement, I was just curious. It makes sense. Thanks!
(ashamed to say I usually use x =>..., which people around me hate)
Details of bundled changes.Comparing: eb6247a...ee45567 eslint-plugin-react-hooks
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says.