Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename press props in experimental event API #15263

Merged
merged 1 commit into from
Mar 30, 2019
Merged

Rename press props in experimental event API #15263

merged 1 commit into from
Mar 30, 2019

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Mar 29, 2019 •
edited

Note: this is for an experimental event API that we're testing out internally at Facebook.

  • onPressIn -> onPressStart
  • onPressOut -> onPressEnd
  • longPressCancelsPress -> onLongPressShouldCancelPress

Ref #15257

@necolas necolas mentioned this pull request Mar 29, 2019
Closed
@sizebot
Copy link

sizebot commented Mar 29, 2019 •
edited

Details of bundled changes.

Comparing: 08055a6...a20fd1e

react-events

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-events.development.js 0.0% -0.2% 1.16 KB 1.16 KB 618 B 617 B UMD_DEV
react-events.production.min.js 0.0% -0.2% 682 B 682 B 431 B 430 B UMD_PROD
react-events.development.js 0.0% -0.2% 996 B 996 B 556 B 555 B NODE_DEV
react-events.production.min.js 0.0% -0.3% 512 B 512 B 354 B 353 B NODE_PROD
react-events-press.development.js +5.0% +5.2% 9.94 KB 10.44 KB 2.47 KB 2.6 KB UMD_DEV
react-events-press.production.min.js 🔺+8.1% 🔺+5.9% 3.94 KB 4.26 KB 1.43 KB 1.51 KB UMD_PROD
react-events-press.development.js +5.1% +5.2% 9.77 KB 10.27 KB 2.43 KB 2.55 KB NODE_DEV
react-events-press.production.min.js 🔺+8.5% 🔺+5.8% 3.78 KB 4.1 KB 1.39 KB 1.47 KB NODE_PROD
ReactEventsPress-dev.js +6.9% +6.3% 9.85 KB 10.52 KB 2.44 KB 2.59 KB FB_WWW_DEV
ReactEventsPress-prod.js 🔺+7.9% 🔺+9.4% 7.78 KB 8.4 KB 1.76 KB 1.92 KB FB_WWW_PROD
react-events-hover.development.js 0.0% -0.1% 4.73 KB 4.73 KB 1.33 KB 1.32 KB UMD_DEV
react-events-hover.production.min.js 0.0% -0.2% 2.12 KB 2.12 KB 904 B 902 B UMD_PROD
react-events-hover.development.js 0.0% -0.1% 4.56 KB 4.56 KB 1.28 KB 1.28 KB NODE_DEV
react-events-hover.production.min.js 0.0% -0.2% 1.95 KB 1.95 KB 846 B 844 B NODE_PROD
react-events-focus.development.js 0.0% -0.1% 2.95 KB 2.95 KB 1.02 KB 1.02 KB UMD_DEV
react-events-focus.production.min.js 0.0% -0.3% 1.39 KB 1.39 KB 678 B 676 B UMD_PROD
react-events-focus.development.js 0.0% -0.1% 2.78 KB 2.78 KB 993 B 992 B NODE_DEV
react-events-focus.production.min.js 0.0% -0.3% 1.22 KB 1.22 KB 615 B 613 B NODE_PROD
react-events-swipe.development.js 0.0% -0.1% 5.98 KB 5.98 KB 1.73 KB 1.72 KB UMD_DEV
react-events-swipe.production.min.js 0.0% -0.2% 2.59 KB 2.59 KB 1.15 KB 1.15 KB UMD_PROD
react-events-swipe.development.js 0.0% -0.1% 5.81 KB 5.81 KB 1.68 KB 1.68 KB NODE_DEV
react-events-swipe.production.min.js 0.0% -0.2% 2.43 KB 2.43 KB 1.09 KB 1.09 KB NODE_PROD
react-events-drag.development.js 0.0% -0.1% 5.27 KB 5.27 KB 1.57 KB 1.57 KB UMD_DEV
react-events-drag.production.min.js 0.0% -0.2% 2.33 KB 2.33 KB 1 KB 1 KB UMD_PROD
react-events-drag.development.js 0.0% -0.1% 5.1 KB 5.1 KB 1.53 KB 1.53 KB NODE_DEV
react-events-drag.production.min.js 0.0% -0.2% 2.17 KB 2.17 KB 973 B 971 B NODE_PROD

Generated by 🚫 dangerJS

@necolas
Rename press props in experimental event API
a20fd1e 
Note: this is for an experimental event API that we're testing out internally at Facebook.

* onPressIn -> onPressStart
* onPressOut -> onPressEnd
* longPressCancelsPress -> onLongPressShouldCancelPress
@necolas necolas force-pushed the react-events/change-press-event-names branch from 10c987e to a20fd1e Compare March 29, 2019 22:59
trueadm
trueadm approved these changes Mar 30, 2019
View reviewed changes
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trueadm trueadm merged commit 7f1f5dd into facebook:master Mar 30, 2019
@necolas necolas deleted the react-events/change-press-event-names branch April 3, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@necolas @sizebot @trueadm @facebook-github-bot