Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to React DevTools for react-events #15267

Closed
bvaughn opened this issue Mar 30, 2019 · 2 comments
Closed

Add support to React DevTools for react-events #15267

bvaughn opened this issue Mar 30, 2019 · 2 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Mar 30, 2019

This could mean a lot of things, longer term, but for the short term I think we need a way to uniquely identify types of EventComponent (something akin to the displayName attribute that custom components support). The information currently available on the Fiber type doesn't provide that.

As for EventTarget types, I see we have a unique symbol for the touch hit type (the only current target type?)- do we plan to add more unique symbols for future target types? If so, this would be sufficient to identify these.

@trueadm
Copy link
Contributor

trueadm commented Mar 30, 2019

EventTarget can indeed have more types, but there's only one right now – plus the user can create their own. I have a PR up that adds these fields to both objects: #15268.

@necolas
Copy link
Contributor

necolas commented Dec 17, 2019

Closing as we're no longer developing the Flare API. See #15257 (comment)

@necolas necolas closed this as completed Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants