Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React events: add delay props to Press module #15340

Merged
merged 3 commits into from Apr 6, 2019
Merged

React events: add delay props to Press module #15340

merged 3 commits into from Apr 6, 2019

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Apr 5, 2019

  • Adds support for delayPressStart and delayPressEnd.
  • Adds tests for basic and integrated behaviour between delays and events.
  • Updates documentation to include expected behaviour of onPressStart and onPress when used with delays.

Ref #15257

@necolas necolas requested a review from trueadm April 5, 2019 21:18
@sizebot
Copy link

sizebot commented Apr 5, 2019 •
edited

Details of bundled changes.

Comparing: 4064ea9...487f28e

react-events

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-events.development.js 0.0% +0.2% 1.16 KB 1.16 KB 616 B 617 B UMD_DEV
react-events.production.min.js 0.0% 🔺+0.2% 682 B 682 B 430 B 431 B UMD_PROD
react-events.development.js 0.0% -0.2% 996 B 996 B 555 B 554 B NODE_DEV
react-events-press.development.js +12.8% +9.0% 11.42 KB 12.88 KB 2.77 KB 3.02 KB UMD_DEV
react-events-press.production.min.js 🔺+14.6% 🔺+9.9% 4.46 KB 5.11 KB 1.58 KB 1.73 KB UMD_PROD
react-events-press.development.js +13.0% +9.1% 11.25 KB 12.71 KB 2.73 KB 2.98 KB NODE_DEV
react-events-press.production.min.js 🔺+15.1% 🔺+9.9% 4.3 KB 4.94 KB 1.53 KB 1.68 KB NODE_PROD
ReactEventsPress-dev.js +13.3% +9.6% 11.52 KB 13.06 KB 2.77 KB 3.04 KB FB_WWW_DEV
ReactEventsPress-prod.js 🔺+15.5% 🔺+10.6% 9.04 KB 10.44 KB 1.98 KB 2.19 KB FB_WWW_PROD
react-events-hover.development.js +1.6% +2.0% 6.63 KB 6.74 KB 1.75 KB 1.79 KB UMD_DEV
react-events-hover.development.js +1.6% +2.1% 6.46 KB 6.57 KB 1.71 KB 1.74 KB NODE_DEV
ReactEventsHover-dev.js +2.3% +2.4% 6.62 KB 6.77 KB 1.72 KB 1.76 KB FB_WWW_DEV
ReactEventsHover-prod.js 🔺+1.1% 🔺+2.0% 5.87 KB 5.94 KB 1.44 KB 1.47 KB FB_WWW_PROD
react-events-focus.production.min.js 0.0% 🔺+0.1% 1.52 KB 1.52 KB 738 B 739 B UMD_PROD
react-events-swipe.production.min.js 0.0% -0.1% 3.29 KB 3.29 KB 1.55 KB 1.55 KB NODE_PROD
react-events-drag.development.js 0.0% 0.0% 7.63 KB 7.63 KB 2.4 KB 2.4 KB NODE_DEV

Generated by 🚫 dangerJS

trueadm
trueadm approved these changes Apr 6, 2019
View reviewed changes
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@necolas necolas merged commit 81a61b1 into facebook:master Apr 6, 2019
NE-SmallTown
NE-SmallTown reviewed Apr 24, 2019
View reviewed changes
packages/react-events/README.md
@@ -3,14 +3,31 @@
*This package is experimental. It is intended for use with the experimental React
events API that is not available in open source builds.*

Event components do not render a host node. They listen to native browser events
dispatched on the host node of their child and transform those events into
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant space 😃

@necolas necolas deleted the react-events/press-delays branch May 3, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NE-SmallTown NE-SmallTown NE-SmallTown left review comments

@trueadm trueadm trueadm approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@necolas @sizebot @trueadm @NE-SmallTown @facebook-github-bot