Experimental Event API: Remove "listener" from event objects #15391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necolas
approved these changes
Apr 12, 2019
| invariant( | ||
| currentEventQueue && currentInstance, | ||
| 'An event responder context was used outside of an event cycle. ' + | ||
| 'Use context.setTimeout() to use asynchronous responder context outside of event cycle .', |
|
ReactDOM: size: 0.0%, gzip: 0.0% Details of bundled changes.Comparing: ed67984...9cb5ccc react-dom
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the logic for attaching a
listenerfield to event objects, which leaks to the user function. InsteaddispatchEventnow takes a listener argument instead. I also tidied up the resetting ofcurrentcontext values to avoid memory leaks and added aninvariantto deal with edge cases at runtime.