Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event API: add more warnings for responder based events #15597

Merged
merged 3 commits into from
May 9, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented May 9, 2019

This PR adds more DEV time warnings to the experimental event system. Attempting to access properties on the event object that are from older synthetic event system will result in these warnings being fired.

@trueadm trueadm requested a review from threepointone May 9, 2019 13:11
@sizebot
Copy link

sizebot commented May 9, 2019

Details of bundled changes.

Comparing: 05d0850...d13b102

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.1% 0.0% 826.56 KB 827.05 KB 188.71 KB 188.78 KB UMD_DEV
react-dom.profiling.min.js 0.0% -0.0% 107.15 KB 107.15 KB 34.8 KB 34.8 KB UMD_PROFILING
react-dom.development.js +0.1% 0.0% 820.97 KB 821.46 KB 187.16 KB 187.23 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 103.98 KB 103.98 KB 33.25 KB 33.25 KB NODE_PROD
react-dom.profiling.min.js 0.0% -0.0% 107.33 KB 107.33 KB 34.14 KB 34.14 KB NODE_PROFILING
ReactDOM-dev.js +0.1% +0.1% 845.71 KB 846.17 KB 188.68 KB 188.78 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% -0.0% 347 KB 347 KB 64.29 KB 64.29 KB FB_WWW_PROD
react-dom-unstable-fire.development.js +0.1% 0.0% 826.88 KB 827.37 KB 188.85 KB 188.93 KB UMD_DEV
react-dom-unstable-fire.production.min.js 0.0% -0.0% 104.01 KB 104.01 KB 33.82 KB 33.82 KB UMD_PROD
react-dom-unstable-fire.profiling.min.js 0.0% -0.0% 107.16 KB 107.16 KB 34.81 KB 34.8 KB UMD_PROFILING
react-dom-unstable-fire.development.js +0.1% 0.0% 821.29 KB 821.78 KB 187.29 KB 187.37 KB NODE_DEV
react-dom-unstable-fire.production.min.js 0.0% -0.0% 104 KB 104 KB 33.26 KB 33.26 KB NODE_PROD
react-dom-unstable-fire.profiling.min.js 0.0% -0.0% 107.34 KB 107.34 KB 34.15 KB 34.15 KB NODE_PROFILING
ReactFire-dev.js +0.1% 0.0% 844.9 KB 845.36 KB 188.68 KB 188.76 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 54.23 KB 54.23 KB 14.98 KB 14.98 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.56 KB 10.56 KB 3.9 KB 3.89 KB UMD_PROD
react-dom-test-utils.development.js 0.0% -0.0% 53.95 KB 53.95 KB 14.91 KB 14.91 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.35 KB 10.35 KB 3.82 KB 3.82 KB NODE_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.76 KB 60.76 KB 15.85 KB 15.84 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.69 KB 10.69 KB 3.67 KB 3.66 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.43 KB 60.43 KB 15.72 KB 15.72 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.43 KB 10.43 KB 3.56 KB 3.56 KB NODE_PROD
react-dom-server.browser.development.js 0.0% -0.0% 136.73 KB 136.73 KB 35.99 KB 35.99 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.14 KB 19.14 KB 7.22 KB 7.22 KB UMD_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 19.07 KB 19.07 KB 7.21 KB 7.21 KB NODE_PROD
react-dom-server.node.development.js 0.0% 0.0% 134.81 KB 134.81 KB 35.6 KB 35.6 KB NODE_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 19.93 KB 19.93 KB 7.51 KB 7.51 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.1% 1.21 KB 1.21 KB 706 B 705 B UMD_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.1 KB 1.1 KB 667 B 666 B NODE_PROD

Generated by 🚫 dangerJS

@trueadm trueadm merged commit 3669b90 into facebook:master May 9, 2019
@trueadm trueadm deleted the more-dev-warnings branch May 9, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants