Rename ReactFeatureFlags to remove the .fb suffix.
#15826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
rickhanlonii
pushed a commit
to rickhanlonii/react
that referenced
this pull request
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In facebook/react-native@69d1ed7 I landed @ide's PR to remove Haste from React Native. In it, I reverted the change to
ReactFeatureFlags.fb.jsto remove the.fbsuffix again because it wasn't necessary: this file only exists at FB and is only required by other files that already have the.fbsuffix. It made the integration of the PR mentioned above into FB's infra easier to do it this way.This PR aligns React and React Native again.