Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suspense] Fix bad loading state not being delayed #15891

Merged
merged 1 commit into from
Jun 14, 2019
Merged

[Suspense] Fix bad loading state not being delayed #15891

merged 1 commit into from
Jun 14, 2019

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Jun 14, 2019

Fixes a bug where a bad loading state is initially suspended, but a subsequent update with the same expiration time causes it to commit immediately.

#foundwithfuzztester

@acdlite
[Suspense] Fix bad loading state not being delayed
d063fda 
Fixes a bug where a bad loading state is initially suspended, but a
subsequent update with the same expiration time causes it to
commit immediately.
@acdlite acdlite requested a review from sebmarkbage June 14, 2019 22:53
@sizebot
Copy link

sizebot commented Jun 14, 2019

ReactDOM: size: 0.0%, gzip: -0.1%

Details of bundled changes.

Comparing: 353e0ee...d063fda

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% 0.0% 109.34 KB 109.35 KB 34.74 KB 34.74 KB NODE_PROFILING
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.76 KB 60.76 KB 15.85 KB 15.85 KB UMD_DEV
ReactDOM-dev.js 0.0% +0.1% 887.15 KB 887.45 KB 197.5 KB 197.61 KB FB_WWW_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.68 KB 10.68 KB 3.67 KB 3.67 KB UMD_PROD
react-dom-unstable-fire.development.js 0.0% +0.1% 867.52 KB 867.82 KB 197.64 KB 197.75 KB UMD_DEV
react-dom-unstable-fire.production.min.js 0.0% 0.0% 106.02 KB 106.03 KB 34.49 KB 34.49 KB UMD_PROD
react-dom-unstable-fire.profiling.min.js 0.0% 0.0% 109.18 KB 109.18 KB 35.46 KB 35.46 KB UMD_PROFILING
react-dom-unstable-fire.development.js 0.0% +0.1% 861.88 KB 862.18 KB 196.06 KB 196.17 KB NODE_DEV
react-dom-server.node.development.js 0.0% -0.0% 135.27 KB 135.27 KB 35.81 KB 35.81 KB NODE_DEV
react-dom-unstable-fire.production.min.js 0.0% 0.0% 106.02 KB 106.02 KB 33.89 KB 33.89 KB NODE_PROD
react-dom.development.js 0.0% +0.1% 867.17 KB 867.48 KB 197.51 KB 197.61 KB UMD_DEV
react-dom-unstable-fire.profiling.min.js 0.0% 0.0% 109.36 KB 109.36 KB 34.75 KB 34.75 KB NODE_PROFILING
react-dom.production.min.js 0.0% 0.0% 106.01 KB 106.01 KB 34.48 KB 34.48 KB UMD_PROD
ReactFire-dev.js 0.0% +0.1% 886.36 KB 886.66 KB 197.43 KB 197.54 KB FB_WWW_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.2 KB 19.2 KB 7.23 KB 7.23 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 109.16 KB 109.16 KB 35.45 KB 35.45 KB UMD_PROFILING
ReactFire-prod.js 0.0% 0.0% 346.17 KB 346.18 KB 63.64 KB 63.65 KB FB_WWW_PROD
react-dom.development.js 0.0% +0.1% 861.53 KB 861.83 KB 195.92 KB 196.03 KB NODE_DEV
ReactFire-profiling.js 0.0% 0.0% 351.44 KB 351.45 KB 64.53 KB 64.54 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 133.33 KB 133.33 KB 35.27 KB 35.27 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 106.01 KB 106.01 KB 33.88 KB 33.88 KB NODE_PROD
react-dom-server.browser.production.min.js 0.0% -0.0% 19.12 KB 19.12 KB 7.22 KB 7.22 KB NODE_PROD
ReactDOM-prod.js 0.0% 0.0% 358.19 KB 358.2 KB 66.11 KB 66.12 KB FB_WWW_PROD
ReactDOMServer-prod.js 0.0% -0.0% 47.93 KB 47.93 KB 11.03 KB 11.03 KB FB_WWW_PROD
ReactDOM-profiling.js 0.0% 0.0% 364.63 KB 364.64 KB 67.22 KB 67.23 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.43 KB 60.43 KB 15.72 KB 15.72 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.1% 10.42 KB 10.42 KB 3.57 KB 3.57 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% -0.1% 1.1 KB 1.1 KB 667 B 666 B NODE_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.81 KB 3.81 KB 1.54 KB 1.53 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% -0.0% 10.81 KB 10.81 KB 3.97 KB 3.97 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.21 KB 1.21 KB 706 B 704 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.64 KB 3.64 KB 1.49 KB 1.49 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% -0.1% 10.56 KB 10.56 KB 3.92 KB 3.91 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.05 KB 1.05 KB 636 B 635 B NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js +0.1% +0.1% 538.67 KB 538.97 KB 112.72 KB 112.82 KB FB_WWW_DEV
react-art.development.js +0.1% +0.1% 597.43 KB 597.73 KB 130.94 KB 131.04 KB UMD_DEV
react-art.production.min.js 0.0% 0.0% 97.14 KB 97.14 KB 29.92 KB 29.92 KB UMD_PROD
react-art.development.js +0.1% +0.1% 528.34 KB 528.64 KB 113.45 KB 113.55 KB NODE_DEV
react-art.production.min.js 0.0% 0.0% 62.12 KB 62.12 KB 19.2 KB 19.2 KB NODE_PROD
ReactART-prod.js 0.0% 0.0% 202.67 KB 202.68 KB 34.5 KB 34.51 KB FB_WWW_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.1% +0.1% 542.02 KB 542.32 KB 116.32 KB 116.43 KB UMD_DEV
react-test-renderer.production.min.js 0.0% 0.0% 63.45 KB 63.46 KB 19.64 KB 19.64 KB UMD_PROD
react-test-renderer.development.js +0.1% +0.1% 537.56 KB 537.86 KB 115.2 KB 115.3 KB NODE_DEV
react-test-renderer.production.min.js 0.0% 0.0% 63.14 KB 63.15 KB 19.43 KB 19.43 KB NODE_PROD
ReactTestRenderer-dev.js +0.1% +0.1% 550 KB 550.3 KB 115.25 KB 115.35 KB FB_WWW_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 11.6 KB 11.6 KB 3.55 KB 3.55 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% -0.0% 36.07 KB 36.07 KB 9.49 KB 9.49 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 11.74 KB 11.74 KB 3.67 KB 3.67 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-dev.js 0.0% +0.1% 661.79 KB 662.09 KB 140.62 KB 140.73 KB RN_FB_DEV
ReactFabric-prod.js 0.0% 0.0% 245.46 KB 245.47 KB 42.52 KB 42.53 KB RN_FB_PROD
ReactNativeRenderer-dev.js 0.0% +0.1% 672.92 KB 673.22 KB 143.24 KB 143.34 KB RN_OSS_DEV
ReactFabric-profiling.js 0.0% 0.0% 253.6 KB 253.61 KB 44.1 KB 44.1 KB RN_FB_PROFILING
ReactNativeRenderer-prod.js 0.0% 0.0% 252.67 KB 252.68 KB 43.71 KB 43.73 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 260.78 KB 260.79 KB 45.34 KB 45.35 KB RN_OSS_PROFILING
ReactNativeRenderer-dev.js 0.0% +0.1% 673.01 KB 673.31 KB 143.29 KB 143.4 KB RN_FB_DEV
ReactNativeRenderer-prod.js 0.0% 0.0% 252.67 KB 252.68 KB 43.72 KB 43.74 KB RN_FB_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 260.77 KB 260.78 KB 45.35 KB 45.36 KB RN_FB_PROFILING
ReactFabric-dev.js 0.0% +0.1% 661.69 KB 661.99 KB 140.58 KB 140.69 KB RN_OSS_DEV
ReactFabric-prod.js 0.0% 0.0% 245.46 KB 245.47 KB 42.51 KB 42.52 KB RN_OSS_PROD
ReactFabric-profiling.js 0.0% 0.0% 253.6 KB 253.61 KB 44.08 KB 44.09 KB RN_OSS_PROFILING

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler-reflection.development.js 0.0% -0.0% 19.14 KB 19.14 KB 6.12 KB 6.12 KB NODE_DEV
react-reconciler-reflection.production.min.js 0.0% 🔺+0.1% 2.51 KB 2.51 KB 1.11 KB 1.11 KB NODE_PROD
react-reconciler-persistent.development.js +0.1% +0.1% 523.98 KB 524.28 KB 110.9 KB 111 KB NODE_DEV
react-reconciler-persistent.production.min.js 0.0% 0.0% 63.3 KB 63.3 KB 19.01 KB 19.01 KB NODE_PROD
react-reconciler.development.js +0.1% +0.1% 526.4 KB 526.7 KB 111.93 KB 112.03 KB NODE_DEV
react-reconciler.production.min.js 0.0% 0.0% 63.29 KB 63.29 KB 19 KB 19 KB NODE_PROD

Generated by 🚫 dangerJS

bvaughn
bvaughn approved these changes Jun 14, 2019
View reviewed changes
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a ton of context on this one but since it's a high-pri fix, I'm going to leave my ✔️

@acdlite acdlite merged commit 788da69 into facebook:master Jun 14, 2019
rickhanlonii pushed a commit to rickhanlonii/react that referenced this pull request Jun 25, 2019
@acdlite @rickhanlonii
[Suspense] Fix bad loading state not being delayed (facebook#15891)
9d86092 
Fixes a bug where a bad loading state is initially suspended, but a
subsequent update with the same expiration time causes it to
commit immediately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn approved these changes

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@acdlite @sizebot @bvaughn @facebook-github-bot