Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flare] Clear pressStart timeout on pointercancel #16067

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

vincentriemer
Copy link
Contributor

While using the Press component on a touchscreen device, if you started a press and subsequently used that press to scroll, any press feedback triggered by pressStart/pressChange still fires which causes some confusing UX. This diff prevents that by clearing the pressStartTimeout on pointercancel.

@sizebot
Copy link

sizebot commented Jul 5, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks!

@trueadm trueadm merged commit bd72b04 into facebook:master Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants