Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flare] Ensure Flare components are no-ops for TestRenderer #16192

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Jul 24, 2019

This PR makes some changes to the TestRenderer to support Flare's new event system design. Specifically:

  • Previous errors are now no-ops.
  • We remove the responders prop from test instances so they don't affect JSON output in snapshots.

@sizebot
Copy link

sizebot commented Jul 24, 2019

Details of bundled changes.

Comparing: 06cc996...9f5e108

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactTestRenderer-dev.js 0.0% +0.1% 597.25 KB 597.36 KB 124.56 KB 124.68 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 39.37 KB 39.37 KB 9.92 KB 9.92 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 11.62 KB 11.62 KB 3.55 KB 3.55 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% -0.0% 33.5 KB 33.5 KB 8.51 KB 8.51 KB NODE_DEV
react-test-renderer.development.js 0.0% +0.1% 585.46 KB 585.62 KB 125.21 KB 125.32 KB UMD_DEV
react-test-renderer.production.min.js 0.0% -0.0% 68.96 KB 68.96 KB 21.09 KB 21.09 KB UMD_PROD
react-test-renderer.development.js 0.0% +0.1% 581.01 KB 581.16 KB 124.08 KB 124.21 KB NODE_DEV

Generated by 🚫 dangerJS

@trueadm trueadm force-pushed the flare-design-test-renderer branch from b494399 to 9f5e108 Compare July 24, 2019 10:23
@trueadm trueadm merged commit 7ad2211 into facebook:master Jul 24, 2019
@trueadm trueadm deleted the flare-design-test-renderer branch July 24, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants