Bugfix: Effects should never have higher than normal priority #16257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The priority of passive effects is supposed to be the same as the priority of the render. This fixes a bug where the priority is sometimes wrong if the effects are flushed early. But the priority should really never be higher than Normal Priority. I'll change that in the next commit.
|
ReactDOM: size: 0.0%, gzip: -0.0% Details of bundled changes.Comparing: e276a5e...2950dbf react-art
react-native-renderer
react-dom
react-test-renderer
react-reconciler
Generated by 🚫 dangerJS |
|
There's a test failing; will look when I get back from coffee Update: Fixed |
Effects currently have the same priority as the render that spawns them. This changes the behavior so that effects always have normal priority, or lower if the render priority is lower (e.g. offscreen prerendering). The implementation is a bit awkward because of the way `renderRoot`, `commitRoot`, and `flushPassiveEffects` are split. This is a known factoring problem that I'm planning to address once 16.9 is released.
acdlite
commented
Jul 30, 2019
| @@ -213,7 +256,4 @@ describe('ReactSchedulerIntegration', () => { | |||
| Scheduler.unstable_flushUntilNextPaint(); | |||
| expect(Scheduler).toHaveYielded(['A', 'B', 'C']); | |||
| }); | |||
|
|
|||
| // TODO | |||
| it.skip('passive effects have render priority even if they are flushed early', () => {}); | |||
There was a problem hiding this comment.
Should probably conduct regular audits of our TODOs :D
sebmarkbage
approved these changes
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The priority of passive effects is supposed to be the same as the priority of the render. (That was the original intended behavior, at least.) The first commit fixes a bug where the priority is sometimes wrong if the effects are flushed early.
However, the priority should really never be higher than Normal Priority.
The second commit changes the behavior so that effects always have normal priority, or lower if the render priority is lower (e.g. offscreen prerendering).
The implementation is a bit awkward because of the way
renderRoot,commitRoot, andflushPassiveEffectsare split. This is a known factoring problem that I'm planning to address once 16.9 is released.