[react-events] usePress from useKeyboard and useTap #16772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
necolas
commented
Sep 13, 2019
necolas
force-pushed
the
react-events/press-from-tap-and-keyboard
branch
from
530a56a
to
5d74159
Compare
Change the test code from: // Trigger a click event
input.dispatchEvent(
new MouseEvent('mousedown', {bubbles: true, cancelable: true}),
);
input.dispatchEvent(
new MouseEvent('mouseup', {bubbles: true, cancelable: true}),
);To this: // Trigger a click event
input.dispatchEvent(
new MouseEvent('mousedown', {
bubbles: true,
cancelable: true,
buttons: 1,
}),
);
input.dispatchEvent(
new MouseEvent('mouseup', {
bubbles: true,
cancelable: true,
buttons: 1,
}),
);And it should fix the test as you now check the |
necolas
force-pushed
the
react-events/press-from-tap-and-keyboard
branch
from
5d74159
to
c0b50d4
Compare
|
Only 2 tests fail now, and they are related to calling preventDefault on a "virtual" click event that was not caused by the "Enter" key, i.e., a screen-reader dispatched the event. The |
necolas
force-pushed
the
react-events/press-from-tap-and-keyboard
branch
5 times, most recently
from
d9cbe74
to
42b6dd6
Compare
Details of bundled changes.Comparing: 494300b...aaa151f react-ui
|
trueadm
approved these changes
Sep 16, 2019
This implements 'usePress' in user-space as a combination of 'useKeyboard' and 'useTap'. The existing 'usePress' API is preserved for now. The previous implementation is moved to 'PressLegacy'.
necolas
force-pushed
the
react-events/press-from-tap-and-keyboard
branch
from
42b6dd6
to
aaa151f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
usePressin user-space as a combination ofuseKeyboardanduseTap(in an either/or configuration). The existingusePressAPI is preserved for now. The previoususePressimplementation is moved toPressLegacy.Demo: https://codesandbox.io/s/usepress-usetap-usekeyboard-fcvg7