Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

must adding comments for JSX? #16

Closed
mz121star opened this issue May 30, 2013 · 4 comments
Closed

must adding comments for JSX? #16

mz121star opened this issue May 30, 2013 · 4 comments

Comments

@mz121star
Copy link

must added the following comments ?why?no another way?!

/**
* @jsx React.DOM
*/

@andreypopp
Copy link
Contributor

@mz121star as I understood, there can be only single comment (pragma?) at the top of a file.

P.S. I also don't like placing pragmas in my source code so I've built reactify source transform for browserify which transforms JSX files with .jsx extension into JS code. Though it doesn't work yet with react-tools from npm due to #10 (fixed but needs to be released on npm).

@zpao
Copy link
Member

zpao commented May 30, 2013

@mz121star It's an unfortunate side effect of releasing parts of the FB/Instagram infrastructure. That's how we do it internally and we didn't have enough time to clean up and get rid of it. That's very high on our list of things to do now that we've launched.

@andreypopp Nice! Cool to see that happening :) I'll push out the npm update shortly.

@mz121star
Copy link
Author

@zpao
thanks, I get it.
react is gorgeous !

@vjeux
Copy link
Contributor

vjeux commented Jul 21, 2013

See #114 :)

@vjeux vjeux closed this as completed Jul 21, 2013
jgebhardt added a commit to jgebhardt/react that referenced this issue Feb 15, 2014
jgebhardt added a commit to jgebhardt/react that referenced this issue Feb 15, 2014
zpao pushed a commit that referenced this issue Feb 15, 2014
zpao pushed a commit that referenced this issue Feb 15, 2014
virophagesp pushed a commit to virophagesp/react that referenced this issue Apr 2, 2024
…patch-2

Revert "refactor import just for more consistent"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants