Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #17121 #17122

Merged
merged 1 commit into from
Jan 17, 2020
Merged

fix #17121 #17122

merged 1 commit into from
Jan 17, 2020

Conversation

BogdanDor
Copy link
Contributor

Browser can't run shell. Only JavaScript.

@sizebot
Copy link

sizebot commented Oct 16, 2019

No significant bundle size changes to report.

Generated by 🚫 dangerJS against 74b0a4b

@trueadm
Copy link
Contributor

trueadm commented Oct 17, 2019

Can you explain what this change enables for you? The current debug commands work fine for me and I'm don't think they need to be changed, unless I'm missing something?

@BogdanDor
Copy link
Contributor Author

Before fix

before_fix

After fix

after_fix

@stale
Copy link

stale bot commented Jan 15, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jan 15, 2020
@necolas necolas merged commit 29b4d07 into facebook:master Jan 17, 2020
@necolas
Copy link
Contributor

necolas commented Jan 17, 2020

Thanks!

@BogdanDor BogdanDor deleted the patch_17121 branch August 27, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants