Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react-interactions] Remove responder root event types + revert #17518. #17577

Merged
merged 1 commit into from
Dec 11, 2019
Merged

[react-interactions] Remove responder root event types + revert #17518. #17577

merged 1 commit into from
Dec 11, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Dec 11, 2019

This PR does a few things to regain some performance changes recently introduced:

This should remove the need to go to commit phase in as many places during initial render, which should improve initial render performance.

@trueadm trueadm changed the title [react-interactions] Remove responder root event types + revert [react-interactions] Remove responder root event types + revert #17518. Dec 11, 2019
@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 11, 2019 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d046291:

Sandbox Source
magical-perlman-9tf5e Configuration

@trueadm trueadm force-pushed the remove-flare-root-events-on-mount branch from b92c34b to d046291 Compare December 11, 2019 14:22
@sizebot
Copy link

sizebot commented Dec 11, 2019 •
edited

Details of bundled changes.

Comparing: 9ac42dd...d046291

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js +0.1% 0.0% 742.96 KB 743.35 KB 157.87 KB 157.92 KB RN_OSS_DEV
ReactNativeRenderer-prod.js 0.0% 0.0% 276.53 KB 276.53 KB 47.68 KB 47.68 KB RN_FB_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 285.46 KB 285.46 KB 49.41 KB 49.41 KB RN_FB_PROFILING
ReactFabric-dev.js -0.0% 0.0% 748.39 KB 748.35 KB 158.69 KB 158.7 KB RN_OSS_DEV
ReactFabric-dev.js -0.0% 0.0% 748.57 KB 748.54 KB 158.78 KB 158.79 KB RN_FB_DEV
ReactNativeRenderer-prod.js 0.0% 0.0% 276.14 KB 276.14 KB 47.61 KB 47.61 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 285.08 KB 285.08 KB 49.34 KB 49.34 KB RN_OSS_PROFILING
ReactNativeRenderer-dev.js +0.1% 0.0% 743.14 KB 743.52 KB 157.96 KB 158.01 KB RN_FB_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js 0.0% 0.0% 614.99 KB 615.19 KB 131.45 KB 131.49 KB UMD_DEV
react-test-renderer.production.min.js 0.0% 0.0% 71.22 KB 71.22 KB 21.91 KB 21.92 KB UMD_PROD
ReactTestRenderer-dev.js +0.1% 0.0% 623.51 KB 623.9 KB 130.46 KB 130.51 KB FB_WWW_DEV
react-test-renderer-shallow.development.js 0.0% 0.0% 38.93 KB 38.93 KB 9.99 KB 9.99 KB UMD_DEV
react-test-renderer-shallow.production.min.js 0.0% 🔺+0.1% 11.6 KB 11.6 KB 3.58 KB 3.58 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% 0.0% 32.88 KB 32.88 KB 8.51 KB 8.51 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% 🔺+0.1% 11.73 KB 11.73 KB 3.69 KB 3.69 KB NODE_PROD
react-test-renderer.development.js 0.0% 0.0% 610.26 KB 610.46 KB 130.25 KB 130.29 KB NODE_DEV
react-test-renderer.production.min.js 0.0% 0.0% 70.93 KB 70.93 KB 21.55 KB 21.55 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js +0.1% 0.0% 612.04 KB 612.42 KB 127.9 KB 127.96 KB FB_WWW_DEV
ReactART-prod.js 🔺+0.3% 🔺+0.2% 234.87 KB 235.58 KB 39.93 KB 40.01 KB FB_WWW_PROD
react-art.development.js 0.0% 0.0% 670.07 KB 670.27 KB 145.78 KB 145.82 KB UMD_DEV
react-art.production.min.js 0.0% 0.0% 106.19 KB 106.19 KB 32.35 KB 32.35 KB UMD_PROD
react-art.development.js 0.0% 0.0% 600.72 KB 600.92 KB 128.37 KB 128.42 KB NODE_DEV
react-art.production.min.js 0.0% 0.0% 71.16 KB 71.16 KB 21.5 KB 21.5 KB NODE_PROD

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js 0.0% 0.0% 123.07 KB 123.07 KB 38.81 KB 38.81 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 140.06 KB 140.06 KB 36.86 KB 36.86 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 20.39 KB 20.39 KB 7.48 KB 7.48 KB UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 55.98 KB 55.98 KB 15.49 KB 15.49 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.88 KB 3.88 KB 1.55 KB 1.55 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 11.18 KB 11.18 KB 4.15 KB 4.15 KB UMD_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.3% 1.21 KB 1.21 KB 710 B 712 B UMD_PROD
react-dom-test-utils.development.js 0.0% 0.0% 54.26 KB 54.26 KB 15.15 KB 15.15 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% +0.1% 3.71 KB 3.71 KB 1.5 KB 1.5 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 🔺+0.1% 10.95 KB 10.95 KB 4.09 KB 4.09 KB NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.05 KB 1.05 KB 642 B 643 B NODE_PROD
react-dom.development.js -0.0% -0.0% 951.04 KB 950.79 KB 215.41 KB 215.39 KB UMD_DEV
react-dom.production.min.js 0.0% 0.0% 119.11 KB 119.11 KB 38.43 KB 38.43 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 122.8 KB 122.8 KB 39.52 KB 39.52 KB UMD_PROFILING
react-dom.development.js -0.0% -0.0% 945.11 KB 944.86 KB 213.83 KB 213.81 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 137.1 KB 137.1 KB 36.09 KB 36.09 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 119.26 KB 119.26 KB 37.76 KB 37.76 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 20.72 KB 20.72 KB 7.61 KB 7.61 KB NODE_PROD
react-dom-server.browser.development.js 0.0% 0.0% 135.99 KB 135.99 KB 35.87 KB 35.87 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 59.97 KB 59.97 KB 15.73 KB 15.73 KB UMD_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10.73 KB 10.73 KB 3.67 KB 3.67 KB UMD_PROD
ReactDOM-dev.js -0.0% -0.0% 970.51 KB 970.44 KB 216.14 KB 216.12 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.3% 🔺+0.6% 401.68 KB 402.79 KB 73.14 KB 73.55 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% 0.0% 59.64 KB 59.64 KB 15.6 KB 15.6 KB NODE_DEV
react-dom-unstable-fizz.node.development.js 0.0% +0.1% 4.42 KB 4.42 KB 1.65 KB 1.65 KB NODE_DEV
ReactDOM-profiling.js +0.1% -0.0% 403.48 KB 403.72 KB 74.14 KB 74.11 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10.48 KB 10.48 KB 3.57 KB 3.58 KB NODE_PROD
react-dom-unstable-fizz.node.production.min.js 0.0% 🔺+0.1% 1.21 KB 1.21 KB 698 B 699 B NODE_PROD

ReactDOM: size: 0.0%, gzip: 0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against d046291

@sizebot
Copy link

sizebot commented Dec 11, 2019 •
edited

Details of bundled changes.

Comparing: 9ac42dd...d046291

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js +0.1% 0.0% 743.13 KB 743.51 KB 157.95 KB 158 KB RN_FB_DEV
ReactNativeRenderer-prod.js 0.0% 0.0% 276.52 KB 276.52 KB 47.67 KB 47.68 KB RN_FB_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 285.45 KB 285.45 KB 49.4 KB 49.4 KB RN_FB_PROFILING
ReactFabric-dev.js -0.0% 0.0% 748.56 KB 748.52 KB 158.77 KB 158.78 KB RN_FB_DEV
ReactFabric-prod.js 0.0% 0.0% 268.18 KB 268.18 KB 46.3 KB 46.3 KB RN_FB_PROD
ReactNativeRenderer-dev.js +0.1% 0.0% 742.95 KB 743.33 KB 157.86 KB 157.92 KB RN_OSS_DEV
ReactNativeRenderer-prod.js 0.0% 0.0% 276.13 KB 276.13 KB 47.6 KB 47.6 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js 0.0% 0.0% 285.06 KB 285.06 KB 49.33 KB 49.33 KB RN_OSS_PROFILING
ReactFabric-dev.js -0.0% 0.0% 748.37 KB 748.34 KB 158.69 KB 158.7 KB RN_OSS_DEV

Size changes (stable)

Generated by 🚫 dangerJS against d046291

@trueadm trueadm merged commit 2afeebd into facebook:master Dec 11, 2019
@trueadm trueadm deleted the remove-flare-root-events-on-mount branch December 11, 2019 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@necolas necolas necolas approved these changes

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trueadm @sizebot @necolas @facebook-github-bot