DevTools build script enhancements #17653
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 430db52:
|
|
Sure |
| ```sh | ||
| yarn build -- react,react-dom,react-is,scheduler --type=NODE | ||
| RELEASE_CHANNEL=experimental \ |
There was a problem hiding this comment.
I keep making versions of this line for myself too, seems like a useful enough command to have its own alias in scripts? (Maybe not in this PR, and I’m happy to do so myself)
There was a problem hiding this comment.
Sure. I'll add a new alias to package for DevTools. Not sure that's exactly what you're suggesting, but it may be worth doing anyway.
There was a problem hiding this comment.
Lemme think about it some more? Just seems so common, but also tribal/hearsay knowledge.
There was a problem hiding this comment.
Okay. For now though I added a yarn build-for-devtools alias because it's silly that everyone should have to remember the exact set of dependencies.
|
|
||
| Once the above packages have been built, you can build the extension by running: | ||
| #### Download from CI | ||
| To use the latest build from CI, run the following command from the root of the repository: |
There was a problem hiding this comment.
It’s not clear that this is an alternative to the previous step.
There was a problem hiding this comment.
Why not? They're subheaders under the same header which says,
You'll need to either build or download those packages first.
There was a problem hiding this comment.
I could make the header size smaller maybe?
There was a problem hiding this comment.
Is there a problem with just having one of them? Like, downloading from CI could be the suggested option, and you have a postscript that mentions that’s you can also build from source if needed.
I’m thinking from perspective of someone following instructions to build the extension, who doesn’t understand what these deps are, or what context they provide. If I had to quickly make a build and followed these instructions, I might have done both steps. Ofc this is just a nit, so feel free to ignore.
There was a problem hiding this comment.
Yes. It's not sufficient.
We probably want to build from source, so we can test both DevTools and React changes.
External contributors (or Mozilla reviewers) probably want to download a CI build because it's faster and their purpose is not to test React.
Resolves #17629
New command: