Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Root event marks #17772

Closed
wants to merge 2 commits into from
Closed

[DO NOT MERGE] Root event marks #17772

wants to merge 2 commits into from

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jan 3, 2020

Creating this work in progress PR to simplify the process of syncing the build to FB for testing.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a2f64b2:

Sandbox Source
currying-dust-mq1tu Configuration

@sizebot
Copy link

sizebot commented Jan 3, 2020

Details of bundled changes.

Comparing: f749045...a2f64b2

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js +1.2% +0.7% 112.29 KB 113.62 KB 28.73 KB 28.94 KB UMD_DEV
react.production.min.js 0.0% -0.0% 12.67 KB 12.67 KB 4.94 KB 4.94 KB UMD_PROD
React-prod.js 0.0% -0.0% 18.01 KB 18.01 KB 4.69 KB 4.69 KB FB_WWW_PROD
React-profiling.js 0.0% -0.0% 18.01 KB 18.01 KB 4.69 KB 4.69 KB FB_WWW_PROFILING
react.profiling.min.js +2.5% +1.7% 16.2 KB 16.6 KB 6.05 KB 6.16 KB UMD_PROFILING
react.development.js +0.1% +0.1% 71.8 KB 71.86 KB 19.06 KB 19.07 KB NODE_DEV
react.production.min.js 0.0% -0.0% 6.96 KB 6.96 KB 2.86 KB 2.86 KB NODE_PROD
React-dev.js 0.0% -0.0% 72.29 KB 72.29 KB 18.41 KB 18.41 KB FB_WWW_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js +0.8% +0.9% 123.16 KB 124.15 KB 38.74 KB 39.1 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 137.71 KB 137.77 KB 36.61 KB 36.62 KB UMD_DEV
react-dom-test-utils.development.js +0.1% +0.1% 54.5 KB 54.55 KB 15.32 KB 15.33 KB UMD_DEV
ReactDOMServer-prod.js 0.0% -0.0% 49 KB 49 KB 11.19 KB 11.19 KB FB_WWW_PROD
react-dom-test-utils.development.js +0.1% 0.0% 52.77 KB 52.83 KB 14.99 KB 15 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.71 KB 3.71 KB 1.5 KB 1.5 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 10.95 KB 10.95 KB 4.09 KB 4.09 KB NODE_PROD
react-dom.development.js +0.5% +0.4% 951.41 KB 955.84 KB 215.16 KB 215.95 KB UMD_DEV
react-dom.production.min.js 0.0% -0.0% 119.19 KB 119.19 KB 38.29 KB 38.29 KB UMD_PROD
react-dom.profiling.min.js +0.8% +0.7% 122.93 KB 123.91 KB 39.52 KB 39.81 KB UMD_PROFILING
react-dom.development.js +0.5% +0.4% 945.47 KB 949.9 KB 213.48 KB 214.27 KB NODE_DEV
react-dom-server.node.development.js 0.0% 0.0% 134.76 KB 134.81 KB 35.82 KB 35.83 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 119.28 KB 119.28 KB 37.61 KB 37.61 KB NODE_PROD
react-dom-server.browser.development.js 0.0% 0.0% 133.65 KB 133.7 KB 35.58 KB 35.59 KB NODE_DEV
ReactDOM-dev.js +0.5% +0.3% 973.35 KB 977.79 KB 216.46 KB 217.21 KB FB_WWW_DEV
ReactDOM-prod.js 0.0% 0.0% 394.15 KB 394.18 KB 72.19 KB 72.2 KB FB_WWW_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.91 KB 60.91 KB 16.07 KB 16.07 KB UMD_DEV
ReactDOM-profiling.js +0.4% +0.7% 405.44 KB 407.18 KB 74.35 KB 74.84 KB FB_WWW_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 10.23 KB 10.23 KB 3.48 KB 3.47 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.61 KB 60.61 KB 16 KB 16 KB NODE_DEV
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 9.97 KB 9.97 KB 3.37 KB 3.37 KB NODE_PROD
ReactDOMServer-dev.js 0.0% -0.0% 139.36 KB 139.36 KB 35.43 KB 35.43 KB FB_WWW_DEV

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer.development.js +0.7% +0.7% 616.27 KB 620.65 KB 131.31 KB 132.19 KB UMD_DEV
react-test-renderer.production.min.js 0.0% 0.0% 71.5 KB 71.5 KB 21.91 KB 21.91 KB UMD_PROD
react-test-renderer-shallow.development.js 0.0% -0.0% 37.83 KB 37.83 KB 9.81 KB 9.81 KB UMD_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 32.37 KB 32.37 KB 8.5 KB 8.5 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 11.79 KB 11.79 KB 3.71 KB 3.71 KB NODE_PROD
react-test-renderer.development.js +0.7% +0.6% 611.54 KB 615.91 KB 130.13 KB 130.89 KB NODE_DEV
react-test-renderer.production.min.js 0.0% -0.0% 71.19 KB 71.2 KB 21.53 KB 21.52 KB NODE_PROD
ReactTestRenderer-dev.js +0.7% +0.6% 627.38 KB 631.82 KB 130.91 KB 131.67 KB FB_WWW_DEV

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactNativeRenderer-dev.js +0.6% +0.5% 744.23 KB 748.67 KB 157.71 KB 158.53 KB RN_OSS_DEV
ReactFabric-dev.js +0.6% +0.5% 734.79 KB 739.24 KB 155.46 KB 156.28 KB RN_OSS_DEV
ReactNativeRenderer-dev.js +0.6% +0.5% 744.41 KB 748.85 KB 157.81 KB 158.62 KB RN_FB_DEV
ReactFabric-prod.js 0.0% -0.0% 265.65 KB 265.65 KB 45.74 KB 45.73 KB RN_OSS_PROD
ReactNativeRenderer-prod.js 0.0% 0.0% 273.57 KB 273.57 KB 47.06 KB 47.07 KB RN_FB_PROD
ReactFabric-profiling.js +0.6% +0.9% 276.78 KB 278.48 KB 47.86 KB 48.28 KB RN_OSS_PROFILING
ReactNativeRenderer-profiling.js +0.6% +0.9% 284.74 KB 286.45 KB 49.21 KB 49.66 KB RN_FB_PROFILING
ReactNativeRenderer-prod.js 0.0% 0.0% 273.18 KB 273.18 KB 46.99 KB 47 KB RN_OSS_PROD
ReactFabric-dev.js +0.6% +0.5% 734.98 KB 739.42 KB 155.55 KB 156.37 KB RN_FB_DEV
ReactNativeRenderer-profiling.js +0.6% +0.9% 284.35 KB 286.06 KB 49.14 KB 49.59 KB RN_OSS_PROFILING
ReactFabric-prod.js 0.0% -0.0% 266 KB 266 KB 45.81 KB 45.8 KB RN_FB_PROD
ReactFabric-profiling.js +0.6% +0.9% 277.12 KB 278.83 KB 47.92 KB 48.34 KB RN_FB_PROFILING

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
Scheduler-prod.js 🔺+0.4% 🔺+0.5% 12.52 KB 12.57 KB 3.05 KB 3.07 KB FB_WWW_PROD
Scheduler-profiling.js +5.8% +4.6% 17.11 KB 18.1 KB 3.95 KB 4.13 KB FB_WWW_PROFILING
scheduler.development.js +13.4% +18.4% 25.29 KB 28.67 KB 6.48 KB 7.68 KB NODE_DEV
SchedulerMock-dev.js +8.9% +9.0% 22.95 KB 24.98 KB 5.46 KB 5.95 KB FB_WWW_DEV
SchedulerMock-prod.js 🔺+0.2% 🔺+0.4% 12.05 KB 12.08 KB 2.83 KB 2.84 KB FB_WWW_PROD
Scheduler-dev.js +8.0% +7.5% 25.72 KB 27.77 KB 6.57 KB 7.06 KB FB_WWW_DEV
scheduler-tracing.development.js +0.5% +0.3% 11.3 KB 11.35 KB 2.84 KB 2.85 KB NODE_DEV
scheduler-unstable_mock.development.js +14.8% +22.3% 22.72 KB 26.1 KB 5.42 KB 6.63 KB UMD_DEV
scheduler-unstable_mock.production.min.js 0.0% 0.0% 4.73 KB 4.73 KB 1.98 KB 1.98 KB UMD_PROD
scheduler-unstable_mock.development.js +15.0% +22.6% 22.53 KB 25.91 KB 5.36 KB 6.57 KB NODE_DEV
scheduler-unstable_mock.production.min.js 0.0% 🔺+0.1% 4.72 KB 4.72 KB 1.92 KB 1.92 KB NODE_PROD

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactART-dev.js +0.7% +0.6% 615.78 KB 620.22 KB 128.39 KB 129.16 KB FB_WWW_DEV
ReactART-prod.js 0.0% -0.0% 236.25 KB 236.25 KB 39.92 KB 39.92 KB FB_WWW_PROD
react-art.development.js +0.8% +0.6% 671.24 KB 676.54 KB 145.69 KB 146.5 KB UMD_DEV
react-art.production.min.js 0.0% -0.1% 106.83 KB 106.83 KB 32.5 KB 32.47 KB UMD_PROD
react-art.development.js +0.7% +0.6% 601.92 KB 606.35 KB 128.28 KB 129.05 KB NODE_DEV
react-art.production.min.js 0.0% -0.1% 71.78 KB 71.79 KB 21.65 KB 21.63 KB NODE_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler-persistent.development.js +0.7% +0.6% 600.37 KB 604.75 KB 126.34 KB 127.09 KB NODE_DEV
react-reconciler-reflection.development.js +0.3% +0.1% 19.27 KB 19.32 KB 6.33 KB 6.34 KB NODE_DEV
react-reconciler-persistent.production.min.js 0.0% 0.0% 72.09 KB 72.09 KB 21.24 KB 21.25 KB NODE_PROD
react-reconciler-reflection.production.min.js 0.0% -0.1% 2.86 KB 2.86 KB 1.24 KB 1.24 KB NODE_PROD
react-reconciler.development.js +0.7% +0.6% 602.92 KB 607.35 KB 127.45 KB 128.23 KB NODE_DEV
react-reconciler.production.min.js 0.0% 0.0% 74.79 KB 74.79 KB 21.91 KB 21.92 KB NODE_PROD

React: size: 0.0%, gzip: -0.0%

Size changes (experimental)

Generated by 🚫 dangerJS against a2f64b2

@sizebot
Copy link

sizebot commented Jan 3, 2020

Details of bundled changes.

Comparing: f749045...a2f64b2

react

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react.development.js +1.2% +0.7% 112.27 KB 113.6 KB 28.73 KB 28.93 KB UMD_DEV
react.profiling.min.js +2.6% +1.6% 15.85 KB 16.25 KB 5.95 KB 6.04 KB UMD_PROFILING
react.development.js +0.1% +0.1% 71.78 KB 71.84 KB 19.06 KB 19.07 KB NODE_DEV
react.production.min.js 0.0% -0.0% 6.54 KB 6.54 KB 2.72 KB 2.72 KB NODE_PROD

react-native-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
ReactFabric-dev.js +0.6% +0.5% 734.78 KB 739.22 KB 155.45 KB 156.27 KB RN_OSS_DEV
ReactFabric-prod.js 0.0% -0.0% 265.64 KB 265.64 KB 45.73 KB 45.72 KB RN_OSS_PROD
ReactNativeRenderer-dev.js +0.6% +0.5% 744.22 KB 748.66 KB 157.7 KB 158.52 KB RN_OSS_DEV
ReactFabric-profiling.js +0.6% +0.9% 276.76 KB 278.47 KB 47.85 KB 48.27 KB RN_OSS_PROFILING
ReactNativeRenderer-prod.js 0.0% 0.0% 273.17 KB 273.17 KB 46.98 KB 46.99 KB RN_OSS_PROD
ReactNativeRenderer-profiling.js +0.6% +0.9% 284.34 KB 286.05 KB 49.13 KB 49.58 KB RN_OSS_PROFILING

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler-persistent.production.min.js 0.0% 0.0% 72.08 KB 72.08 KB 21.24 KB 21.24 KB NODE_PROD
react-reconciler.development.js +0.7% +0.6% 602.91 KB 607.34 KB 127.45 KB 128.23 KB NODE_DEV
react-reconciler.production.min.js 0.0% 0.0% 72.06 KB 72.07 KB 21.23 KB 21.24 KB NODE_PROD
react-reconciler-reflection.development.js +0.3% +0.1% 19.25 KB 19.31 KB 6.33 KB 6.34 KB NODE_DEV
react-reconciler-persistent.development.js +0.7% +0.6% 600.36 KB 604.73 KB 126.33 KB 127.09 KB NODE_DEV

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.92 KB 19.92 KB 7.39 KB 7.39 KB NODE_PROD
react-dom-test-utils.development.js +0.1% 0.0% 52.76 KB 52.81 KB 14.99 KB 15 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 115.35 KB 115.35 KB 37.18 KB 37.17 KB UMD_PROD
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.59 KB 60.59 KB 15.99 KB 15.99 KB NODE_DEV
react-dom.profiling.min.js +0.8% +0.9% 118.98 KB 119.97 KB 38.36 KB 38.72 KB UMD_PROFILING
react-dom-unstable-native-dependencies.production.min.js 0.0% -0.0% 9.96 KB 9.96 KB 3.37 KB 3.36 KB NODE_PROD
react-dom.development.js +0.5% +0.4% 945.45 KB 949.88 KB 213.45 KB 214.25 KB NODE_DEV
react-dom.production.min.js 0.0% -0.0% 115.42 KB 115.42 KB 36.54 KB 36.54 KB NODE_PROD
react-dom.profiling.min.js +0.8% +0.9% 119.18 KB 120.17 KB 37.66 KB 37.99 KB NODE_PROFILING
react-dom-server.browser.development.js 0.0% 0.0% 137.69 KB 137.75 KB 36.61 KB 36.61 KB UMD_DEV
react-dom-server.browser.production.min.js 0.0% -0.0% 19.99 KB 19.99 KB 7.4 KB 7.4 KB UMD_PROD
react-dom-test-utils.development.js +0.1% 0.0% 54.48 KB 54.54 KB 15.31 KB 15.32 KB UMD_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 11.17 KB 11.17 KB 4.14 KB 4.14 KB UMD_PROD
react-dom-server.browser.development.js 0.0% 0.0% 133.62 KB 133.68 KB 35.58 KB 35.59 KB NODE_DEV
react-dom-unstable-native-dependencies.development.js 0.0% -0.0% 60.89 KB 60.89 KB 16.07 KB 16.06 KB UMD_DEV
react-dom-server.node.development.js 0.0% 0.0% 134.73 KB 134.79 KB 35.81 KB 35.82 KB NODE_DEV
react-dom.development.js +0.5% +0.4% 951.39 KB 955.82 KB 215.13 KB 215.92 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.33 KB 20.33 KB 7.55 KB 7.55 KB NODE_PROD

scheduler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
scheduler-unstable_mock.development.js +14.9% +22.5% 22.71 KB 26.08 KB 5.41 KB 6.63 KB UMD_DEV
scheduler-unstable_mock.production.min.js 0.0% 0.0% 4.72 KB 4.72 KB 1.98 KB 1.98 KB UMD_PROD
scheduler-unstable_mock.development.js +15.0% +22.7% 22.52 KB 25.89 KB 5.35 KB 6.57 KB NODE_DEV
scheduler-unstable_mock.production.min.js 0.0% 🔺+0.1% 4.71 KB 4.71 KB 1.91 KB 1.91 KB NODE_PROD
scheduler-tracing.development.js +0.5% +0.3% 11.29 KB 11.34 KB 2.84 KB 2.85 KB NODE_DEV
scheduler-tracing.production.min.js 0.0% 🔺+0.3% 728 B 728 B 383 B 384 B NODE_PROD
scheduler.development.js +13.4% +18.5% 25.28 KB 28.66 KB 6.48 KB 7.67 KB NODE_DEV

react-art

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-art.production.min.js 0.0% 0.0% 104.33 KB 104.33 KB 31.8 KB 31.8 KB UMD_PROD
react-art.development.js +0.8% +0.6% 671.22 KB 676.52 KB 145.68 KB 146.49 KB UMD_DEV
react-art.development.js +0.7% +0.6% 601.9 KB 606.33 KB 128.28 KB 129.05 KB NODE_DEV
react-art.production.min.js 0.0% -0.0% 69.33 KB 69.33 KB 20.97 KB 20.96 KB NODE_PROD

react-test-renderer

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-test-renderer-shallow.development.js 0.0% -0.0% 37.81 KB 37.81 KB 9.8 KB 9.8 KB UMD_DEV
react-test-renderer-shallow.development.js 0.0% -0.0% 32.35 KB 32.35 KB 8.49 KB 8.49 KB NODE_DEV
react-test-renderer-shallow.production.min.js 0.0% -0.0% 11.78 KB 11.78 KB 3.7 KB 3.7 KB NODE_PROD
react-test-renderer.development.js +0.7% +0.7% 616.25 KB 620.62 KB 131.3 KB 132.18 KB UMD_DEV
react-test-renderer.production.min.js 0.0% 0.0% 71.48 KB 71.48 KB 21.89 KB 21.9 KB UMD_PROD
react-test-renderer.development.js +0.7% +0.6% 611.51 KB 615.89 KB 130.12 KB 130.87 KB NODE_DEV
react-test-renderer.production.min.js 0.0% -0.0% 71.17 KB 71.17 KB 21.51 KB 21.5 KB NODE_PROD

ReactDOM: size: 0.0%, gzip: -0.0%

Size changes (stable)

Generated by 🚫 dangerJS against a2f64b2

@necolas necolas added the React Core Team Opened by a member of the React Core Team label Jan 8, 2020
@bvaughn
Copy link
Contributor Author

bvaughn commented Jan 23, 2020 •
edited

This PR is for testing. Don't need to actually keep it open, so long as the branch is around. (Our sync script pulls from the PR.)

@bvaughn bvaughn closed this Jan 23, 2020
@bvaughn bvaughn mentioned this pull request Jun 15, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bvaughn @sizebot @necolas @facebook-github-bot