Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: High-pri setState causes primary tree to get unhidden #18357

Closed
gaearon opened this issue Mar 20, 2020 · 1 comment · Fixed by #18411
Closed

Bug: High-pri setState causes primary tree to get unhidden #18357

gaearon opened this issue Mar 20, 2020 · 1 comment · Fixed by #18411
Assignees
@sebmarkbage
Labels
Type: Bug

Comments

@gaearon
Copy link
Collaborator

gaearon commented Mar 20, 2020

Repro: https://codesandbox.io/s/fast-water-4i4jb

Notice the flash. I'd expect suspended to be true during the high pri render.
@gaearon gaearon added Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Type: Bug and removed Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Mar 20, 2020
@gaearon
Copy link
Collaborator Author

gaearon commented Mar 20, 2020

Repro with two sibling components: https://codesandbox.io/s/vigilant-nightingale-deb0u. During the high pri render, we don't go into ProfilePage at all.

This was referenced Mar 25, 2020
Merged
Merged
@gaearon gaearon mentioned this issue Apr 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebmarkbage sebmarkbage

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix: Do not unhide a suspended tree without finishing the suspended update acdlite/react
2 participants
@sebmarkbage @gaearon