Look ma, new docs! #188
Merged
Look ma, new docs! #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let us keep docs in order on the filesystem but have reasonable permalinks. If we add something at 02- it doesn't result in lots of broken links.
This is still the same amount of duplication, except way easier to parse. Docs nav now lives in `_config.yml` and you must restart jekyll to see changes to that list (since config is only read at jekyll launch)
Here are some ideas that I think work better: - 15 repetitions of "React". Removed a few. - The "two main ideas" weren't clearly separated. I put them under different headers and simplified the wording. - The "Give it Five Minutes section didn't sound as reassuring. Made it sound more certain.
Tweaked the intro page
(unlinked likebutton tutorial - not updated enough for public)
bvaughn
pushed a commit
to bvaughn/react
that referenced
this pull request
Aug 13, 2019
Don't select search result unless user does something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a giant refactor of all the React docs. I've ported over some of the old docs, written some new ones, and moved over some internal dex guides to the open-source docs. I say we err on the side of merging and fixing issues as we and the community discover them.