-
Notifications
You must be signed in to change notification settings - Fork 45.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: devtools "rendered at" for child components uses value of top component #18818
Comments
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment! |
The tooltip is fine now but the description in the right column seems misleading to me. |
Can still reproduce in latest DevTools and React version. @bvaughn Am I misunderstanding what the "rendered at" in the side-panel is supposed to say? |
The "rendered at" time in this label is not specific to the component. It's describing the commit that the component rendered as part of. If you have suggestions for changing the label, I'm open to hearing them. I think we could use the Fiber's |
When you mean "label" you refer to the side-panel? What I don't understand is why we do display different information in the tooltip. I would just expect the same timings displayed in the tooltip to appear in the side-panel. Because it's a bit unintuitive that the side-panel would first show a timing Basically we have timing
vs
Don't display "rendered at" under the component header because it's not specific to the component. Instead
Though ultimately I would still prefer to display the timing information of the tooltip in the side-panel. You have to be very precise to view the component specific timing depending on the hoverable area.
|
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment! |
Bump |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment! |
React version: 17.0.2
devtools version: 4.18.0-f58bbcf9a
Steps To Reproduce
Link to code example: https://codesandbox.io/s/vibrant-thunder-bm3so
The current behavior
"rendered at" uses the value from the root component
The expected behavior
it should use the same value that is displayed in the tooltip. Otherwise I don't see much value in displaying it since I could just read the value directly from the root. I thought it was intended for very dense flamegraphs e.g.
The text was updated successfully, but these errors were encountered: