Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eslint-plugin-react-hooks peerDependency warning with eslint@7.0.0 #18876

Closed
AviVahl opened this issue May 9, 2020 · 1 comment · Fixed by #18878
Closed

eslint-plugin-react-hooks peerDependency warning with eslint@7.0.0 #18876

AviVahl opened this issue May 9, 2020 · 1 comment · Fixed by #18878
Labels
Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug

Comments

@AviVahl
Copy link

AviVahl commented May 9, 2020 •
edited

The current behavior

eslint@7.0.0 has been released yesterday. eslint-plugin-react-hooks gets a peerDependency warning:

npm WARN eslint-plugin-react@7.19.0 requires a peer of eslint@^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.

The expected behavior

Ensure compatibility with the newly released major and add to peerDependencies.
@AviVahl AviVahl added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label May 9, 2020
@AviVahl
Copy link
Author

AviVahl commented May 9, 2020 •
edited

Oh I just realized eslint-plugin-react is coming from another repo: https://github.com/yannickcr/eslint-plugin-react

Will open an issue there as well and edit this one.

@AviVahl AviVahl changed the title eslint-plugin-react(-hooks) peerDependency warnings with eslint@7.0.0 eslint-plugin-react-hooks peerDependency warning with eslint@7.0.0 May 9, 2020
@AviVahl AviVahl mentioned this issue May 9, 2020
Closed
@ljharb ljharb mentioned this issue May 9, 2020
Closed
19 tasks
This was referenced May 9, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eslint-plugin-react-hooks): Support ESLint 7.x MichaelDeBoey/react
1 participant
@AviVahl