Don't bailout after Suspending in Legacy Mode #19216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
gaearon
commented
Jun 30, 2020
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 77ec289:
|
Details of bundled changes.Comparing: 47ff31a...77ec289 react-dom
react-native-renderer
react-art
react-test-renderer
react-reconciler
Size changes (experimental) |
Details of bundled changes.Comparing: 47ff31a...77ec289 react-dom
react-art
react-test-renderer
react-native-renderer
react-reconciler
ReactDOM: size: 0.0%, gzip: -0.0% Size changes (stable) |
|
Seems like I'll need a broader fix with the effect tag so that it works for other Fiber types too. |
gaearon
changed the title
gaearon
force-pushed
the
susp
branch
3 times, most recently
from
438537d
to
ea251a6
Compare
gaearon
commented
Jun 30, 2020
|
Upd. |
acdlite
reviewed
Jun 30, 2020
| // consumer produces a changed value, it will set this to true. Otherwise, | ||
| // the component will assume the children have not changed and bail out. | ||
| didReceiveUpdate = false; | ||
| if ((current.effectTag & ForceUpdateForLegacySuspense) !== NoEffect) { |
There was a problem hiding this comment.
I wouldn't expect this check to be necessary, since whenever you hit this block, you'll always fall into the updateSimpleMemoComponent path, so you can do everything in there.
There was a problem hiding this comment.
There was a problem hiding this comment.
This isn't specific to SimpleMemo though. This block is to fix the issue for all other cases (e.g. normal memo, or a function component). See the rest of the tests.
There was a problem hiding this comment.
Ah. God Legacy Mode is annoying. OK that makes sense then.
acdlite
reviewed
Jun 30, 2020
acdlite
reviewed
Jun 30, 2020
|
Upd2. I think the generic check is still needed because this is a fix for more than SimpleMemo path. #18844 was about functions in general, with the referential equality bailout as the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17356.
Fixes #18844.
Has regression tests + verified sandboxes work.
Builds on the test case in #18572 and approach from #18572 (comment).