Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with capture phase non-delegated events #19452

Merged
merged 1 commit into from Jul 25, 2020
Merged

Fix issue with capture phase non-delegated events #19452

merged 1 commit into from Jul 25, 2020

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Jul 25, 2020 •
edited

This PR fixes an issue where non-delegated events can over-fire when in the capture phase. This was because we were emulating their propagation, which wasn't necessary, as native capture phase event listeners always propagate in the capture phase (even if they don't in the bubble phase).

@trueadm trueadm requested a review from gaearon July 25, 2020 10:04
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 25, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 25, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fbab96d:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Jul 25, 2020

Details of bundled changes.

Comparing: 125d1a1...fbab96d

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.1% +0.1% 886.02 KB 886.85 KB 202.97 KB 203.2 KB NODE_DEV
ReactDOMForked-prod.js -0.0% 0.0% 408.36 KB 408.34 KB 75.49 KB 75.51 KB FB_WWW_PROD
react-dom-server.node.development.js 0.0% -0.0% 137.33 KB 137.33 KB 36.49 KB 36.49 KB NODE_DEV
react-dom.production.min.js 0.0% 0.0% 119.79 KB 119.83 KB 38.47 KB 38.49 KB NODE_PROD
ReactDOMForked-profiling.js -0.0% 0.0% 423.43 KB 423.42 KB 78.12 KB 78.14 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 143.44 KB 143.44 KB 36.7 KB 36.7 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.26 KB 20.26 KB 7.6 KB 7.6 KB NODE_PROD
ReactDOMTesting-dev.js +0.1% +0.1% 986.48 KB 987.32 KB 220.24 KB 220.47 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 61.82 KB 61.82 KB 17.91 KB 17.91 KB NODE_DEV
ReactDOMTesting-prod.js -0.0% 0.0% 415.52 KB 415.5 KB 77.83 KB 77.85 KB FB_WWW_PROD
react-dom.development.js +0.1% +0.1% 930.78 KB 931.64 KB 205.44 KB 205.68 KB UMD_DEV
react-dom.production.min.js 0.0% 🔺+0.1% 119.69 KB 119.73 KB 39.19 KB 39.21 KB UMD_PROD
react-dom.profiling.min.js 0.0% +0.1% 123.6 KB 123.63 KB 40.36 KB 40.38 KB UMD_PROFILING
ReactDOMForked-dev.js +0.1% +0.1% 1021.67 KB 1022.5 KB 226.49 KB 226.72 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% -0.2% 123.85 KB 123.89 KB 39.75 KB 39.68 KB NODE_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 19.92 KB 19.92 KB 7.46 KB 7.46 KB UMD_PROD
ReactDOM-dev.js +0.1% +0.1% 1018.35 KB 1019.19 KB 226.18 KB 226.42 KB FB_WWW_DEV
ReactDOM-prod.js -0.0% 0.0% 406.92 KB 406.9 KB 75.16 KB 75.18 KB FB_WWW_PROD
ReactDOM-profiling.js -0.0% 0.0% 421.38 KB 421.36 KB 77.79 KB 77.81 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 19.84 KB 19.84 KB 7.44 KB 7.44 KB NODE_PROD

Size changes (stable)

Generated by 🚫 dangerJS against fbab96d

@sizebot
Copy link

sizebot commented Jul 25, 2020

Details of bundled changes.

Comparing: 125d1a1...fbab96d

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js +0.1% +0.1% 923.13 KB 923.96 KB 209.77 KB 210.02 KB NODE_DEV
ReactDOMForked-prod.js -0.0% 0.0% 397.23 KB 397.21 KB 73.82 KB 73.84 KB FB_WWW_PROD
react-dom.production.min.js 0.0% 0.0% 124.59 KB 124.62 KB 39.92 KB 39.94 KB NODE_PROD
ReactDOMForked-profiling.js -0.0% 0.0% 412.24 KB 412.22 KB 76.48 KB 76.5 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 145.03 KB 145.03 KB 36.89 KB 36.89 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% 0.0% 20.72 KB 20.72 KB 7.67 KB 7.68 KB NODE_PROD
ReactDOMTesting-dev.js +0.1% +0.1% 958.32 KB 959.15 KB 214.8 KB 215.04 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 61.83 KB 61.83 KB 17.92 KB 17.92 KB NODE_DEV
ReactDOMTesting-prod.js -0.0% 0.0% 403.27 KB 403.25 KB 76.01 KB 76.03 KB FB_WWW_PROD
react-dom-unstable-fizz.node.development.js 0.0% -0.1% 5.61 KB 5.61 KB 1.86 KB 1.86 KB NODE_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 5.36 KB 5.36 KB 1.8 KB 1.8 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.3% 1.17 KB 1.17 KB 667 B 665 B NODE_PROD
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.3% 1.2 KB 1.2 KB 706 B 704 B UMD_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 4.87 KB 4.87 KB 1.71 KB 1.7 KB NODE_DEV
react-dom.development.js +0.1% +0.1% 969.69 KB 970.55 KB 212.31 KB 212.54 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% -0.2% 1.01 KB 1.01 KB 616 B 615 B NODE_PROD
react-dom.production.min.js 0.0% 0.0% 124.44 KB 124.45 KB 40.66 KB 40.67 KB UMD_PROD
react-dom.profiling.min.js 0.0% -0.0% 129.62 KB 129.64 KB 42.31 KB 42.3 KB UMD_PROFILING
ReactDOMForked-dev.js +0.1% +0.1% 996.13 KB 996.96 KB 221.72 KB 221.98 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% +0.1% 129.96 KB 129.99 KB 41.54 KB 41.59 KB NODE_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 20.38 KB 20.38 KB 7.54 KB 7.54 KB UMD_PROD
ReactDOM-dev.js +0.1% +0.1% 992.81 KB 993.65 KB 221.45 KB 221.72 KB FB_WWW_DEV
ReactDOM-prod.js -0.0% 0.0% 395.79 KB 395.77 KB 73.55 KB 73.57 KB FB_WWW_PROD
ReactDOM-profiling.js -0.0% 0.0% 410.18 KB 410.17 KB 76.17 KB 76.2 KB FB_WWW_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 20.3 KB 20.3 KB 7.52 KB 7.52 KB NODE_PROD
ReactDOMServer-dev.js 0.0% -0.0% 143.33 KB 143.33 KB 36.43 KB 36.43 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 66.92 KB 66.92 KB 18.42 KB 18.42 KB UMD_DEV

Size changes (experimental)

Generated by 🚫 dangerJS against fbab96d

@trueadm trueadm changed the title Fix issue with capture phase non-bubbling events Fix issue with capture phase non-delegated events Jul 25, 2020
@trueadm trueadm merged commit 242a50a into facebook:master Jul 25, 2020
@trueadm trueadm deleted the non-bubbling-3 branch July 25, 2020 11:32
@trueadm trueadm mentioned this pull request Jul 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trueadm @sizebot @gaearon @facebook-github-bot