Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow up fix to 19452 #19454

Merged
merged 1 commit into from Jul 27, 2020
Merged

Follow up fix to 19452 #19454

merged 1 commit into from Jul 27, 2020

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Jul 25, 2020

This PR is a follow up to #19452. In that PR I forgot to reset the target fiber to be that of the container for when we deal with non-delegated events. Otherwise, we'll only ever process the event.target, which I forgot to test against.

@trueadm trueadm requested a review from gaearon July 25, 2020 12:00
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 25, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 34baa28:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Jul 25, 2020

Details of bundled changes.

Comparing: 242a50a...34baa28

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 886.36 KB 886.57 KB 203.03 KB 203.05 KB NODE_DEV
ReactDOMForked-prod.js 🔺+0.1% 🔺+0.1% 408.19 KB 408.69 KB 75.39 KB 75.44 KB FB_WWW_PROD
react-dom.production.min.js 0.0% 🔺+0.1% 119.46 KB 119.48 KB 38.43 KB 38.45 KB NODE_PROD
ReactDOMForked-profiling.js +0.1% +0.1% 423.27 KB 423.77 KB 78.02 KB 78.07 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 143.44 KB 143.44 KB 36.7 KB 36.7 KB UMD_DEV
react-dom-server.node.production.min.js 0.0% -0.0% 20.26 KB 20.26 KB 7.6 KB 7.6 KB NODE_PROD
ReactDOMTesting-dev.js 0.0% 0.0% 986.97 KB 987.16 KB 220.31 KB 220.33 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 60.88 KB 60.88 KB 17.65 KB 17.65 KB NODE_DEV
ReactDOMTesting-prod.js 🔺+0.1% 🔺+0.1% 415.33 KB 415.83 KB 77.76 KB 77.81 KB FB_WWW_PROD
react-dom-test-utils.production.min.js 0.0% -0.0% 12.7 KB 12.7 KB 4.96 KB 4.96 KB NODE_PROD
react-dom.development.js 0.0% 0.0% 931.11 KB 931.32 KB 205.51 KB 205.54 KB UMD_DEV
react-dom.production.min.js 0.0% 🔺+0.1% 119.36 KB 119.38 KB 39.1 KB 39.12 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 123.25 KB 123.28 KB 40.3 KB 40.32 KB UMD_PROFILING
ReactDOMForked-dev.js 0.0% 0.0% 1022.19 KB 1022.38 KB 226.55 KB 226.58 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% +0.2% 123.52 KB 123.54 KB 39.64 KB 39.72 KB NODE_PROFILING
ReactDOM-dev.js 0.0% 0.0% 1018.85 KB 1019.04 KB 226.24 KB 226.26 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.1% 🔺+0.1% 406.73 KB 407.23 KB 75.08 KB 75.13 KB FB_WWW_PROD
ReactDOM-profiling.js +0.1% +0.1% 421.19 KB 421.69 KB 77.7 KB 77.75 KB FB_WWW_PROFILING
ReactDOMServer-dev.js 0.0% -0.0% 147.37 KB 147.37 KB 37.43 KB 37.43 KB FB_WWW_DEV
ReactDOMServer-prod.js 0.0% 0.0% 47.54 KB 47.54 KB 11.14 KB 11.14 KB FB_WWW_PROD
react-dom-test-utils.development.js 0.0% -0.0% 65.9 KB 65.9 KB 18.18 KB 18.17 KB UMD_DEV

Size changes (stable)

Generated by 🚫 dangerJS against 34baa28

@sizebot
Copy link

sizebot commented Jul 25, 2020

Details of bundled changes.

Comparing: 242a50a...34baa28

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.development.js 0.0% 0.0% 923.47 KB 923.68 KB 209.84 KB 209.86 KB NODE_DEV
ReactDOMForked-prod.js 🔺+0.1% 0.0% 397.06 KB 397.56 KB 73.75 KB 73.78 KB FB_WWW_PROD
react-dom.production.min.js 0.0% 0.0% 124.25 KB 124.27 KB 39.87 KB 39.88 KB NODE_PROD
ReactDOMForked-profiling.js +0.1% 0.0% 412.07 KB 412.57 KB 76.39 KB 76.42 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 145.03 KB 145.03 KB 36.89 KB 36.89 KB UMD_DEV
ReactDOMTesting-dev.js 0.0% 0.0% 958.81 KB 959 KB 214.89 KB 214.91 KB FB_WWW_DEV
react-dom-test-utils.development.js 0.0% -0.0% 60.89 KB 60.89 KB 17.66 KB 17.66 KB NODE_DEV
ReactDOMTesting-prod.js 🔺+0.1% 🔺+0.1% 403.09 KB 403.59 KB 75.92 KB 75.97 KB FB_WWW_PROD
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 5.36 KB 5.36 KB 1.81 KB 1.8 KB UMD_DEV
react-dom-unstable-fizz.node.production.min.js 0.0% -0.3% 1.17 KB 1.17 KB 668 B 666 B NODE_PROD
react-dom.development.js 0.0% 0.0% 970.02 KB 970.23 KB 212.38 KB 212.4 KB UMD_DEV
react-dom-unstable-fizz.browser.production.min.js 0.0% 🔺+0.2% 1.01 KB 1.01 KB 616 B 617 B NODE_PROD
react-dom.production.min.js 0.0% 0.0% 124.08 KB 124.1 KB 40.61 KB 40.61 KB UMD_PROD
react-dom.profiling.min.js 0.0% 0.0% 129.27 KB 129.3 KB 42.21 KB 42.23 KB UMD_PROFILING
ReactDOMForked-dev.js 0.0% 0.0% 996.64 KB 996.83 KB 221.82 KB 221.86 KB FB_WWW_DEV
react-dom.profiling.min.js 0.0% 0.0% 129.62 KB 129.64 KB 41.56 KB 41.57 KB NODE_PROFILING
react-dom-server.browser.production.min.js 0.0% -0.0% 20.38 KB 20.38 KB 7.55 KB 7.54 KB UMD_PROD
ReactDOM-dev.js 0.0% 0.0% 993.3 KB 993.49 KB 221.55 KB 221.59 KB FB_WWW_DEV
ReactDOM-prod.js 🔺+0.1% 0.0% 395.6 KB 396.1 KB 73.46 KB 73.5 KB FB_WWW_PROD
ReactDOM-profiling.js +0.1% 0.0% 410 KB 410.5 KB 76.09 KB 76.12 KB FB_WWW_PROFILING
ReactDOMServer-dev.js 0.0% -0.0% 143.33 KB 143.33 KB 36.43 KB 36.43 KB FB_WWW_DEV

Size changes (experimental)

Generated by 🚫 dangerJS against 34baa28

gaearon
gaearon approved these changes Jul 27, 2020
View reviewed changes
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in but then consider a refactor where we use delegation for capture-phase events.

@trueadm trueadm merged commit 05344fa into facebook:master Jul 27, 2020
@trueadm trueadm deleted the non-bubbling-4 branch July 27, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@trueadm @sizebot @gaearon @facebook-github-bot