Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: A menu item in tutorial doesn't get highlighted on click #19828

Closed
izdwuut opened this issue Sep 14, 2020 · 2 comments · Fixed by reactjs/react.dev#3260
Closed

Bug: A menu item in tutorial doesn't get highlighted on click #19828

izdwuut opened this issue Sep 14, 2020 · 2 comments · Fixed by reactjs/react.dev#3260

Comments

@izdwuut
Copy link

izdwuut commented Sep 14, 2020

Hi!

I've been working my way through your marvelous tutorial when I've noticed that once you click on Overview > Inspecting the Starter Code in menu, the element doesn't get highlighted. It's because you use <h3 id="inspecting-the-starter-code">...</h3> instead of <h2 id="inspecting-the-starter-code">...</h2> in your markup. This should be a subheader, not header.

React version: Doesn't apply.
Browser: Firefox Developer Edition 81.0b9 (64-bit).

Steps To Reproduce

  1. Go to https://reactjs.org/tutorial/tutorial.html.
  2. Click on Overview > Inspecting the Starter Code menu item.

Link to code example: doesn't apply.

The current behavior

The Overview > Inspecting the Starter Code menu element doesn't get highlighted on click.

The expected behavior

The Overview > Inspecting the Starter Code element should get highlighted on click.

@izdwuut izdwuut added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Sep 14, 2020
@izdwuut izdwuut changed the title Bug: A menu item in tutorial doesn't get highlighted Bug: A menu item in tutorial doesn't get highlighted on click Sep 14, 2020
@eps1lon
Copy link
Collaborator

eps1lon commented Sep 14, 2020

Thanks for the report!

@eps1lon eps1lon added Component: ReactIs and removed Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Component: ReactIs labels Sep 14, 2020
@izdwuut
Copy link
Author

izdwuut commented Sep 14, 2020

Anytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants