Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default release channel for download-experimental-build script #20663

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jan 26, 2021

Recent changes to the build scripts made this a required param, but it didn't make sense for the download-experimental-build script (used when building DevTools) to ever download anything but an experimental release, so I added a default value for that param.

Before

Screen Shot 2021-01-26 at 9 29 39 AM

After

Screen Shot 2021-01-26 at 9 30 30 AM

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 26, 2021
@bvaughn
Copy link
Contributor Author

bvaughn commented Jan 26, 2021

I tried to use the defaultOption flag provided by command-line-args for this (just adding it conditionally before calling command-line-args) but it seems to only support boolean values. 🤷‍♂️ This is fine.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f117fc4:

Sandbox Source
React Configuration

@sizebot
Copy link

sizebot commented Jan 26, 2021

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against f117fc4

@sizebot
Copy link

sizebot commented Jan 26, 2021

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against f117fc4

@bvaughn bvaughn merged commit db5945e into facebook:master Jan 26, 2021
@bvaughn bvaughn deleted the download-experimental-build branch January 26, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants