Redundant condition in react-devtools-shared

[nlspnsgen]

This is not important but it seems that this if statement is superfluous since typeof always returns a string.

react/packages/react-devtools-shared/src/hydration.js

Line 246 in 553440b

if (typeof data[Symbol.iterator]) {

[bvaughn]

Yeah, looks like maybe this got broken during a refactor (ce65df7).

I think this line should be

if (typeof data[Symbol.iterator] === 'function') {

Actually since we check the type right above, maybe the condition should have just been deleted entirely. (I don't remember this code very well.)

[E-Aho]

Hey, I'm gonna pick this up and try to get a PR through to tidy this :)

This would be my first issue in this repo. I've given the contribution guidelines a read through, and so will do my best to follow all the CoC and best practices in there.

[bvaughn]

This issue is all yours @erikaho! 😄

I've added the "good first issue (taken)" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

Cheers!

[E-Aho]

Hey! Raised a PR for this.

Couldn't find any unit tests that covered the dehydrate function here, and I started to write a few, but thought that it was probably out of scope of this PR. Can definitely create some tests for this function if needed though!