Don't warn for upper case tag name if it's a custom element #21156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
React Core Team
This replicates what we do on the client.
sebmarkbage
force-pushed
the
dontwarnforcustomelementcasing
branch
from
2266075
to
b218955
Compare
|
Why is it legit to have a custom element with non-lowercase name? What's the point? |
|
Comparing: 9ed0167...b218955 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Apr 11, 2021
This replicates what we do on the client.
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Apr 13, 2021
This replicates what we do on the client.
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Apr 16, 2021
This replicates what we do on the client.
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Apr 16, 2021
This replicates what we do on the client.
acdlite
pushed a commit
to acdlite/react
that referenced
this pull request
Apr 19, 2021
This replicates what we do on the client.
koto
pushed a commit
to koto/react
that referenced
this pull request
Jun 15, 2021
This replicates what we do on the client.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #21076
This replicates what we do on the client already.