Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools: Update tests to fix warnings/errors #21748

Merged
merged 1 commit into from Jun 25, 2021

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jun 24, 2021

Some new ones had slipped in (e.g. deprecated ReactDOM.render warning from 18)

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 24, 2021
@sizebot
Copy link

sizebot commented Jun 24, 2021

Comparing: 386e8f2...cffe5d0

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.39 kB 127.39 kB = 40.83 kB 40.83 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 130.20 kB 130.20 kB = 41.74 kB 41.74 kB
facebook-www/ReactDOM-prod.classic.js = 405.62 kB 405.62 kB = 74.99 kB 74.99 kB
facebook-www/ReactDOM-prod.modern.js = 394.04 kB 394.04 kB = 73.22 kB 73.22 kB
facebook-www/ReactDOMForked-prod.classic.js = 405.62 kB 405.62 kB = 74.99 kB 74.99 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against cffe5d0

Some new ones had slipped in (e.g. deprecated ReactDOM.render message from 18)
@bvaughn bvaughn merged commit 73ffce1 into facebook:master Jun 25, 2021
@bvaughn bvaughn deleted the devtools-fix-tests branch June 25, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants