Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline discreteUpdates #21784

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Jul 1, 2021

This API is only used by the event system, to set the event priority for the scope of a function. We don't need it anymore because we can modify the priority directly, like we already do for continuous input events.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 1, 2021
@sizebot
Copy link

sizebot commented Jul 1, 2021

Comparing: 0f09f14...652d55d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.08 kB 126.98 kB = 40.74 kB 40.67 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.89 kB 129.79 kB = 41.65 kB 41.61 kB
facebook-www/ReactDOM-prod.classic.js = 404.40 kB 404.12 kB = 74.82 kB 74.74 kB
facebook-www/ReactDOM-prod.modern.js = 393.10 kB 392.82 kB = 73.09 kB 73.02 kB
facebook-www/ReactDOMForked-prod.classic.js = 404.40 kB 404.12 kB = 74.82 kB 74.74 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 652d55d

@acdlite acdlite force-pushed the inline-discreteupdates branch 2 times, most recently from f4c4712 to e8717d5 Compare July 1, 2021 22:14
This API is only used by the event system, to set the event priority for
the scope of a function. We don't need it anymore because we can modify
the priority directly, like we already do for continuous input events.
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ezpz

@acdlite acdlite merged commit bfa50f8 into facebook:main Jul 12, 2021
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
This API is only used by the event system, to set the event priority for
the scope of a function. We don't need it anymore because we can modify
the priority directly, like we already do for continuous input events.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants