Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset inspected element cache in the event of an error #21821

Merged
merged 2 commits into from Jul 8, 2021

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Jul 7, 2021

This prevents React from immediately erroring again when re-rendering (since the previous error would have been stored in the Suspense cache)

Resolves #21819

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jul 7, 2021
@sizebot
Copy link

sizebot commented Jul 7, 2021

Comparing: 241485a...14b8286

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.20 kB 127.20 kB = 40.76 kB 40.76 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 130.01 kB 130.01 kB = 41.67 kB 41.67 kB
facebook-www/ReactDOM-prod.classic.js = 404.75 kB 404.75 kB = 74.83 kB 74.83 kB
facebook-www/ReactDOM-prod.modern.js = 393.15 kB 393.15 kB = 73.07 kB 73.07 kB
facebook-www/ReactDOMForked-prod.classic.js = 404.75 kB 404.75 kB = 74.83 kB 74.83 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 14b8286

This prevents React from immediately erroring again when re-rendering (since the previous error would have been stored in the Suspense cache)
@bvaughn bvaughn force-pushed the devtools-clear-cache-before-retry branch from 84a3d76 to 1855e83 Compare July 8, 2021 17:49
@bvaughn bvaughn force-pushed the devtools-clear-cache-before-retry branch from 1855e83 to 14b8286 Compare July 8, 2021 17:53
@bvaughn bvaughn merged commit 92f3414 into facebook:main Jul 8, 2021
@bvaughn bvaughn deleted the devtools-clear-cache-before-retry branch July 8, 2021 18:07
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DevTools] Improve "retry" function for inspected component props/state/hooks
3 participants