Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] Scheduling Profiler umbrella task #21866

Closed
14 of 20 tasks
bvaughn opened this issue Jul 13, 2021 · 3 comments
Closed
14 of 20 tasks

[DevTools] Scheduling Profiler umbrella task #21866

bvaughn opened this issue Jul 13, 2021 · 3 comments
Assignees
Labels
Component: Developer Tools Resolution: Stale Automatically closed due to inactivity

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Jul 13, 2021

The Scheduling Profiler is currently only accessible at react-scheduling-profiler.vercel.app and very few people know about it. Furthermore, the User Timing API marks that power this profiler are only enabled in the experimental release channel, which almost no one uses. We believe this profiler is an important part of understanding React’s concurrent scheduling and app performance.

Initial release

Follow up work

  • Create a discussion thread on the React 18 Working Group about it and gather usability feedback.
  • Implement some sort of feature detection to hide this panel for react-dom builds that don't have enableSchedulingProfiler enabled? (Maybe only show it for v18+) Probably not a good idea. You might want to import a profile on a non-React site.
  • Follow ups from DevTools: Scheduling profiler: Add vertical scroll bar #22005
  • Try coloring component rendering to match suspense colors for components that suspended. (May require updating the React profiler marks)
  • Revisit the concept of batching. It's currently defined as one or more renders followed by a potential commit (unless the render is explicitly cancelled). I think this doesn't properly take into account interleaved work (e.g. offscreen/idle pre-rendering). Batch ID should probably also take lane(s) into consideration.
@bvaughn
Copy link
Contributor Author

bvaughn commented Jul 13, 2021

Note some prerequisite was done in #19892

@bvaughn bvaughn changed the title [DevTools] Release the Scheduling Profiler in the Chrome extension [DevTools] Scheduling Profiler umbrella task Aug 12, 2021
@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jan 8, 2022
Copy link

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Developer Tools Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

No branches or pull requests

1 participant