[DevTools] Add React Devtools Extension Startup and File Structure to OVERVIEW.md #22283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…view I previously made an excalidraw to map out how the React Devtools Extension code is laid out. This should probably be expanded and have better accessibility (because it's an image and not text) but leaving this here so it's more easily accessible in the meantime.
facebook-github-bot
added
CLA Signed
React Core Team
lunaruan
changed the title
jstejada
approved these changes
Sep 9, 2021
packages/react-devtools/OVERVIEW.md
Outdated
|
|
||
| ## Package Specific Details | ||
|
|
||
| ### Devtools Extension |
There was a problem hiding this comment.
are these the sections to fill out later?
There was a problem hiding this comment.
Eep good callout removed the extra title
There was a problem hiding this comment.
nit: I would maybe combine and reword these titles slightly
I'm not sure this is "package specific" so much as it is...a diagram of how the pieces fit together at a high level. Maybe "Overview diagram" or something?
bvaughn
approved these changes
Sep 9, 2021
packages/react-devtools/OVERVIEW.md
Outdated
|
|
||
| ## Package Specific Details | ||
|
|
||
| ### Devtools Extension |
There was a problem hiding this comment.
nit: I would maybe combine and reword these titles slightly
I'm not sure this is "package specific" so much as it is...a diagram of how the pieces fit together at a high level. Maybe "Overview diagram" or something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made an excalidraw to map out how the React Devtools Extension files are laid out and how initialization works.
Future TODO: Expand this section, add how standalone/inline files are laid out, and make this not an image and/or add accessibility text