[DevTools] Extension reports logged events when feature flag is enabled #22475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstejada
commented
Sep 30, 2021
bvaughn
approved these changes
Sep 30, 2021
| @@ -73,6 +75,7 @@ module.exports = { | |||
| 'process.env.DEVTOOLS_PACKAGE': `"react-devtools-extensions"`, | |||
| 'process.env.DEVTOOLS_VERSION': `"${DEVTOOLS_VERSION}"`, | |||
| 'process.env.GITHUB_URL': `"${GITHUB_URL}"`, | |||
| 'process.env.LOGGING_URL': `"${LOGGING_URL}"`, | |||
There was a problem hiding this comment.
nit: I don't think we need this in the backend config, do we? This variable is only referenced in code imported form main.js which is built by the frontend config.
yeah, it would be nice to set something up here. for the time being i manually verified that events were going all the way through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit implements an event logger for the DevTools extensions (
react-devtools-extension), which will report events that are logged from the DevTools runtime to an iframe that knows how to process those events. Note that this will only happen when theenableLoggerfeature flag is enabled, which will only be enabled for internal (fb-only) builds of DevTools.Note that for now, the
enableLoggerfeature flag is fully disabled, so this commit should have no observable effect on DevTools after landing.How did you test this change?
enableLoggerfeature flag and verified that events were correctly communicated to iframe that loads an internal endpoint.