Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevTools] Log basic usage events #22478

Merged
merged 2 commits into from Sep 30, 2021
Merged

[DevTools] Log basic usage events #22478

merged 2 commits into from Sep 30, 2021

Conversation

jstejada
Copy link
Contributor

@jstejada jstejada commented Sep 30, 2021 •
edited

Summary

This commit adds a few additional events to the Logger to capture basic usage events for when DevTools is loaded, and when different tabs are selected.

NOTE that this only applies when the enableLogger feature flag is enabled, which is only the case for internal builds of DevTools

How did you test this change?

  • yarn flow
  • yarn test
  • yarn test-build-devtools
  • ran extension with logging enabled, verified that works and events are logged when switching tabs:
    image
  • ran standalone app and verified that switching apps works correctly and that event is logged correctly in that case

bvaughn
bvaughn reviewed Sep 30, 2021
View reviewed changes
packages/react-devtools-shared/src/devtools/views/DevTools.js Outdated
}
setTab(tabId);
},
[tab, setTab, showTabBar],
Copy link
Contributor

@bvaughn bvaughn Sep 30, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tab shouldn't be in the deps. That changes all the time. Also we don't even reference it.

bvaughn
bvaughn approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved except for the dependencies thing.

@jstejada jstejada merged commit 2825a08 into facebook:main Sep 30, 2021
@jstejada jstejada deleted the metrics branch October 1, 2021 15:09
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
@zhengjitf
[DevTools] Log basic usage events (facebook#22478)
d07c156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvaughn bvaughn bvaughn approved these changes

@lunaruan lunaruan lunaruan approved these changes

Assignees
No one assigned
Labels
CLA Signed Component: Developer Tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jstejada @bvaughn @lunaruan @facebook-github-bot