Add Scheduling Profiler GK link to Timeline UI for FB build #22730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
This is a constant source of confusion for FB engineers trying to figure out why Chrome profiling data does not have any React marks.
bvaughn
force-pushed
the
facebook-timeline-gk
branch
from
a2d9f1b
to
c85c9aa
Compare
steveluscher
approved these changes
Nov 9, 2021
| Enable the | ||
| <a | ||
| className={styles.WelcomeInstructionsListItemLink} | ||
| href="https://fburl.com/react-devtools-scheduling-profiler-gk" |
There was a problem hiding this comment.
Maybe make this reload the page with ?gk_debug&gk_enable=react_enable_scheduling_profiler instead?
There was a problem hiding this comment.
Ooh, that's an interesting suggestion. Guess we could also enable the react_enable_profile_timer GK too and remove the "profiling build" instruction entirely. Let me think about that!
There was a problem hiding this comment.
Okay I think I might pass on this for now for a few reasons:
- Facebook internal build doesn't necessarily mean you're viewing a Facebook website (that supports URL params like
gk_debug). - I don't think there's a way to detect if the user has already loaded a build with the right GKs (and avoid showing them a reload button unnecessarily).
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
…#22730) This is a constant source of confusion for FB engineers trying to figure out why Chrome profiling data does not have any React marks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a constant source of confusion for FB engineers trying to figure out why Chrome profiling data does not have any React marks.
Internal Facebook build will now show the following additional line:
