Migrate from CLIEngine to the new ESLint class.

[elas7]

Summary

In ESLint 8, CLIEngine was removed. To migrate from version 7 to 8, we need to replace CLIEngine with the new ESLint class.

More information here:

• Legacy documentation of the CLIEngine class.
• Documentation of the ESLint class.
• Migration guide.

How did you test this change?

I tested the following commands before and after the migration:

• For yarn lint and yarn linc, the output was the same.
• For yarn lint --fix and yarn linc --fix, the output was the same and the fixable errors got fixed.

Pass example:

$ yarn linc
yarn run v1.22.17
$ node ./scripts/tasks/linc.js
Linting changed files...
> git merge-base HEAD main
> git diff --name-only --diff-filter=ACMRTUB c0c71a868560b3042847722659579418bfe2d7e1
> git ls-files --others --exclude-standard

Lint passed for changed files.
✨  Done in 3.38s.

Error example:

$ yarn linc
yarn run v1.22.17
$ node ./scripts/tasks/linc.js
Linting changed files...
> git merge-base HEAD main
> git diff --name-only --diff-filter=ACMRTUB c0c71a868560b3042847722659579418bfe2d7e1
> git ls-files --others --exclude-standard

/Users/XXX/projects/react/scripts/devtools/publish-release.js
  60:7   error  'a' is assigned a value but never used  no-unused-vars
  60:11  error  Multiple spaces found before ';'        no-multi-spaces

✖ 2 problems (2 errors, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

Lint failed for changed files.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[elas7]

I had to add destructuring to prevent passing _, which minimist generates by default. Otherwise, ESlint returns this error:

yarn linc
yarn run v1.22.17
$ node ./scripts/tasks/linc.js
Linting changed files...
Lint passed for changed files.
(node:84712) UnhandledPromiseRejectionWarning: Error: Invalid Options:
- Unknown options: _
    at processOptions (/Users/XXX/projects/react/node_modules/eslint/lib/eslint/eslint.js:273:15)
    at new ESLint (/Users/XXX/projects/react/node_modules/eslint/lib/eslint/eslint.js:416:34)

[elas7]

Same here.

[elas7]

The new class no longer returns a global report with errorCount and warningCount, so I calculated them manually.

[sizebot]

Comparing: c0c71a8...0987cfd

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	129.68 kB	129.68 kB	=	41.46 kB	41.46 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	134.66 kB	134.66 kB	=	42.94 kB	42.94 kB
facebook-www/ReactDOM-prod.classic.js	=	424.11 kB	424.11 kB	=	78.18 kB	78.18 kB
facebook-www/ReactDOM-prod.modern.js	=	412.66 kB	412.66 kB	=	76.43 kB	76.43 kB
facebook-www/ReactDOMForked-prod.classic.js	=	424.11 kB	424.11 kB	=	78.18 kB	78.18 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 0987cfd

[gaearon]

thank you