Track currently replaying event #22853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
React Core Team
|
Comparing: ca106a0...7a61e9c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
gaearon
commented
Dec 2, 2021
salazarm
approved these changes
Dec 2, 2021
Co-authored-by: Dan Abramov <dan.abramov@me.com>
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
* Track currently replaying event Co-authored-by: Dan Abramov <dan.abramov@me.com> * Add warnings Co-authored-by: Marco Salazar <salazarm@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No intentional functional changes (but bugs are possible).
We're going to need to track whether an event is currently being replayed in #22680 without relying on the flags (because from React's perspective it would be a regular browser event). In #22680, we solve this by keeping a Set of currently replaying events. However, we've also added an invariant to forbid reentrancy. I think this means the Set is unnecessary. If we're confident React dispatching isn't reentrant, let's just keep the "current" event, similar to how we track other "current" things in the reconciler.