Add authorization header to artifacts request #24106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
salazarm
reviewed
Mar 15, 2022
| @@ -9,6 +9,15 @@ const {getArtifactsList, logPromise} = require('../utils'); | |||
| const theme = require('../theme'); | |||
|
|
|||
| const run = async ({build, cwd, releaseChannel}) => { | |||
| const CIRCLE_TOKEN = process.env.CIRCLE_CI_API_TOKEN; | |||
| console.log({CIRCLE_TOKEN}); | |||
salazarm
approved these changes
Mar 15, 2022
CircleCI's artifacts API was updated; it now errors unless you're logged in. This affects any of our workflows that download build artifacts. To fix, I added an authorization header to the request.
acdlite
force-pushed
the
download-artifacts-auth
branch
from
8abc62a
to
a013cc9
Compare
|
Hrmm I guess this doesn't work for sizebot because PRs don't have access to environment variables |
|
Maybe need to set up a proxy, at least temporarily |
acdlite
force-pushed
the
download-artifacts-auth
branch
from
98f4a27
to
67953b5
Compare
|
Comparing: 0412f0c...ab32703 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
acdlite
force-pushed
the
download-artifacts-auth
branch
from
67953b5
to
f0d08e8
Compare
We can't use the normal download-build script in sizebot because it depends on the CircleCI artifacts API, which was recently changed to require authorization. And we can't pass an authorization token without possibly leaking it to the public, since we run sizebot on PRs from external contributors. As a temporary workaround, this job will pull the artifacts from a public mirror that I set up. But we should find some other solution so we don't have to maintain the mirror.
acdlite
force-pushed
the
download-artifacts-auth
branch
from
f0d08e8
to
ab32703
Compare
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
* Add authorization header to artifacts request CircleCI's artifacts API was updated; it now errors unless you're logged in. This affects any of our workflows that download build artifacts. To fix, I added an authorization header to the request. * Update sizbot to pull artifacts from public mirror We can't use the normal download-build script in sizebot because it depends on the CircleCI artifacts API, which was recently changed to require authorization. And we can't pass an authorization token without possibly leaking it to the public, since we run sizebot on PRs from external contributors. As a temporary workaround, this job will pull the artifacts from a public mirror that I set up. But we should find some other solution so we don't have to maintain the mirror.
acdlite
added a commit
to acdlite/react
that referenced
this pull request
May 18, 2022
This reverts commit facebook#24106. There was a regression in CircleCI's artifacts API recently where you could no longer access artifacts without an authorization token. This broke our size reporting CI job because we can't use an authorization token on external PRs without potentially leaking it. As a temporary workaround, I changed the size reporting job to use a public mirror of our build artifacts. The CircleCI API has since been fixed to no longer require authorization, so we can revert the workaround.
acdlite
added a commit
to acdlite/react
that referenced
this pull request
May 18, 2022
This reverts facebook#24106. There was a regression in CircleCI's artifacts API recently where you could no longer access artifacts without an authorization token. This broke our size reporting CI job because we can't use an authorization token on external PRs without potentially leaking it. As a temporary workaround, I changed the size reporting job to use a public mirror of our build artifacts. The CircleCI API has since been fixed to no longer require authorization, so we can revert the workaround.
acdlite
added a commit
that referenced
this pull request
May 18, 2022
This reverts #24106. There was a regression in CircleCI's artifacts API recently where you could no longer access artifacts without an authorization token. This broke our size reporting CI job because we can't use an authorization token on external PRs without potentially leaking it. As a temporary workaround, I changed the size reporting job to use a public mirror of our build artifacts. The CircleCI API has since been fixed to no longer require authorization, so we can revert the workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CircleCI's artifacts API was updated; it now errors unless you're logged in. This affects any of our workflows that download build artifacts.
To fix, I added an authorization header to the request.