Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Update Example render for React v18 #24259

Merged
merged 1 commit into from Apr 3, 2022
Merged

Conversation

nnnnoel
Copy link
Contributor

@nnnnoel nnnnoel commented Apr 2, 2022

Summary

Update Example render for React v18

ReactDOM.render is deprecated

How did you test this change?

@facebook-github-bot
Copy link

Hi @nnnnoel!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@nnnnoel nnnnoel changed the title Update Example render for React v18 [docs] Update Example render for React v18 Apr 2, 2022
@sizebot
Copy link

sizebot commented Apr 2, 2022

Comparing: b8cfda1...5646bd8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.30 kB 131.30 kB = 41.97 kB 41.97 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.36 kB 136.36 kB = 43.42 kB 43.42 kB
facebook-www/ReactDOM-prod.classic.js = 432.75 kB 432.75 kB = 79.58 kB 79.58 kB
facebook-www/ReactDOM-prod.modern.js = 417.75 kB 417.75 kB = 77.21 kB 77.21 kB
facebook-www/ReactDOMForked-prod.classic.js = 432.75 kB 432.75 kB = 79.58 kB 79.58 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 5646bd8

@gaearon gaearon merged commit e912da9 into facebook:main Apr 3, 2022
rickhanlonii pushed a commit that referenced this pull request Apr 13, 2022
rickhanlonii pushed a commit that referenced this pull request Apr 14, 2022
rickhanlonii pushed a commit that referenced this pull request Apr 14, 2022
zhengjitf pushed a commit to zhengjitf/react that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants