[DevTools] Add jest-cli --reactVersion argument
#24556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
React Core Team
|
Comparing: 4c03bb6...21f7fbc Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
bvaughn
approved these changes
May 14, 2022
scripts/jest/jest-cli.js
Outdated
| @@ -314,6 +329,10 @@ function getEnvars() { | |||
| envars.VARIANT = true; | |||
| } | |||
|
|
|||
| if (argv.reactVersion) { | |||
| envars.REACT_VERSION = semver.minVersion(argv.reactVersion).version; | |||
There was a problem hiding this comment.
I wonder if you considered using coerce rather than minVersion?
There was a problem hiding this comment.
😮 How did I miss that in the docs?! I think it ends up being the same as minVersion but it's more descriptive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--reactVersionargument. This argument is only used in DevTools. When this is specified, run only the tests that have the// @reactVersionpragma that satisfies the semver version range. Otherwise, run tests as normal