Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs Rake "update_version" command to strip trailing spaces #24

Closed
zpao opened this issue May 30, 2013 · 1 comment
Closed

Fix docs Rake "update_version" command to strip trailing spaces #24

zpao opened this issue May 30, 2013 · 1 comment

Comments

@zpao
Copy link
Member

zpao commented May 30, 2013

Looks like it's mostly a problem with Ruby 1.8 yaml vs 1.9 yaml. One strips the trailing space and the other leaves it in.

There's also the issue of reordering. So at the very least we shouldn't re-write _config.yml if the version is the same.

zpao added a commit that referenced this issue May 30, 2013
Doesn't fix, but mostly addresses the concerns in #24. Some churn at
version bumps is far better than what we have right now.
@zpao
Copy link
Member Author

zpao commented Jun 19, 2013

I changed this to only rewrite the file on version bumps in de2832c, so I'm going to call it good enough and close this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants